Review main Merged

55835[BUGFIX] Add placeholder to date picker form elements

Ralf Zimmermann CR +2 V +2 Easy +7 −1 updated 02/27/18, 13:55

Commit message

Add the possibility to define a placeholder html attribute for
date picker form elements.

Review

  • Code review CR +2
    • Frans Saris +2
    • Oliver Hader +1
  • Verified V +2
    • Frans Saris +2
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1114

  1. Ralf Zimmermann uploaded patch set 1 02/20/18, 17:20

  2. TYPO3com voted on patch set 1 V +1 02/20/18, 17:34 Completed build in 14m 27s on Tue, 20 Feb, 06:34 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19932

  3. Oliver Hader updated the commit message in patch set 2 02/20/18, 18:06

  4. TYPO3com voted on patch set 2 V -1 02/20/18, 18:18 Completed build in 11m 09s on Tue, 20 Feb, 07:18 PM Test Summary: 1 of 31054 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19939

  5. TYPO3com voted on patch set 2 V +1 02/20/18, 18:26 Completed build in 30m 42s on Tue, 20 Feb, 07:26 PM Test Summary: 30902 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19939

  6. Oliver Hader voted on patch set 2 V +1 CR +1 02/20/18, 18:57

  7. Oliver Hader commented on patch set 2 02/20/18, 18:57

    There's another issue which is however not caused by this patch and probably originates in the Yaml::save() function of the Symfony component, see https://forge.typo3.org/issues/83985
  8. Frans Saris voted on patch set 2 CR +1 02/20/18, 19:19

  9. Frans Saris voted on patch set 2 V +2 CR +2 02/20/18, 19:22

  10. Frans Saris merged patch set 3 02/20/18, 19:24

  11. Frans Saris commented on patch set 3 02/20/18, 19:24

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 807d800fbe2a882073af14c1d0bbd6848e68fea4
  12. Frank Nägler commented on patch set 3 02/27/18, 13:33

    post -1: In 8.7 / I get: #1476107295: PHP Warning: Illegal string offset 'placeholder' in vendor/typo3/cms/typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php line 84
  13. Frans Saris commented on patch set 3 02/27/18, 13:50

    ah, this happens when you leave the placeholder empty in the backend. @Ralf shouldn't it be something like below. As the `additionalAttributes` overrides the default value from YAML config? ``` $placeholder = $this->arguments['additionalAttributes']['placeholder'] ?? $this->arguments['placeholder']; ```
  14. Frank Nägler commented on patch set 3 02/27/18, 13:55

    it breaks existing forms, if you not update the form definitions. the second fallback should be an empty string I think. $placeholder = $this->arguments['additionalAttributes']['placeholder'] ?? $this->arguments['placeholder'] ?? ''; or something like that.