Review TYPO3_8-7 Merged

55837[BUGFIX] Hide readonly elements in summary page and emails

Oliver Hader CR +2 V +2 Normal +80 −0 updated 02/22/18, 18:38

Commit message

Hide readonly form elements within the summary page and emails.

Review

  • Code review CR +2
    • Oliver Hader +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
  • Verified V +2
    • Oliver Hader +2
    • Björn Jacob +1
    • Ralf Zimmermann +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1014

  1. Oliver Hader uploaded patch set 1 02/20/18, 17:33

  2. Oliver Hader commented on patch set 1 02/20/18, 17:36

    RenderAllFormValuesViewHelper.php:92

    The _isHiddenFormElement intentionally has not been added as stated in previous https://review.typo3.org/#/c/53383/ change for master
  3. TYPO3com voted on patch set 1 V +1 02/20/18, 17:50 Completed build in 16m 18s on Tue, 20 Feb, 06:50 PM Test Summary: 58113 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1913

  4. Ralf Zimmermann updated the commit message in patch set 2 02/21/18, 08:27

  5. Björn Jacob commented on patch set 2 CR -1 02/21/18, 08:45

    Please wait with merge. This patch adds documentation. We are trying to get the docs of TYPO3 v8 and v9 in sync again.
  6. TYPO3com voted on patch set 2 V +1 02/21/18, 08:46 Completed build in 12m 27s on Wed, 21 Feb, 09:46 AM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1927

  7. Björn Jacob updated the commit message in patch set 3 02/22/18, 09:13

  8. TYPO3com voted on patch set 3 V +1 02/22/18, 09:25 Completed build in 12m 11s on Thu, 22 Feb, 10:25 AM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1931

  9. Ralf Zimmermann uploaded patch set 4 02/22/18, 10:27

  10. Björn Jacob voted on patch set 4 V +1 CR +1 02/22/18, 10:29

  11. TYPO3com voted on patch set 4 V +1 02/22/18, 10:41 Completed build in 14m 34s on Thu, 22 Feb, 11:41 AM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1932

  12. Ralf Zimmermann voted on patch set 4 V +1 CR +1 02/22/18, 12:42

  13. Oliver Hader voted on patch set 4 V +2 CR +2 02/22/18, 18:37

  14. Oliver Hader merged patch set 5 02/22/18, 18:38