Review TYPO3_8-7 Merged

55842[BUGFIX] Refactor record querying in deep nested structures in recycler

Christian Kuhn CR +2 V +2 Hard +211 −58 updated 02/20/18, 19:40

Commit message

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1

Issues 1

Files 4

Review log 4

  1. Christian Kuhn uploaded patch set 1 02/20/18, 19:33

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 02/20/18, 19:37

  3. Christian Kuhn voted on patch set 1 V +2 CR +2 02/20/18, 19:39

  4. Christian Kuhn merged patch set 2 02/20/18, 19:40