Review main Merged

55850[TASK] Remove usage of extbase from viewpage module

Georg Ringer CR +2 V +2 Normal +67 −54 updated 02/22/18, 18:49

Commit message

Remove the overhead of extbase from the backend extension "viewpage".

Review

  • Code review CR +2
    • Frans Saris +2
    • Benjamin Franzke +1
    • Mathias Schreiber +1
  • Verified V +2
    • Frans Saris +2
    • Benjamin Franzke +1
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1621

  1. Georg Ringer uploaded patch set 1 02/21/18, 04:55

  2. Frans Saris voted on patch set 1 CR +1 02/21/18, 07:08

  3. Anja Leichsenring updated the commit message in patch set 2 02/21/18, 08:02

  4. Anja Leichsenring commented on patch set 2 02/21/18, 08:02

    added a newline into commit message to trigger bamboo
  5. TYPO3com voted on patch set 2 V +1 02/21/18, 08:11 Completed build in 09m 32s on Wed, 21 Feb, 09:11 AM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19960

  6. Anja Leichsenring updated the commit message in patch set 3 02/21/18, 08:22

  7. TYPO3com voted on patch set 3 V +1 02/21/18, 08:32 Completed build in 10m 15s on Wed, 21 Feb, 09:32 AM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19961

  8. Benjamin Franzke commented on patch set 3 02/21/18, 10:14

    ViewModuleController.php:95

    Now that there's the PSR-7 request GenerealUtility::_GP should not be used. Do you mind to change that with this patch, or rather defer that for a separate one?
  9. Benjamin Franzke uploaded patch set 4 02/22/18, 05:44

  10. Benjamin Franzke commented on patch set 4 02/22/18, 05:49

    ViewModuleController.php:95 Reply Unresolved

    I pushed a patchset doing that – it's quite expansive: I switched the class to strict types as we need the page id and language id in alot of functions (and i didn't want to fiddle around with castings in every function). Feel free to revert to patch set 3 if that's too much, then I would push this change as a separate patch.
  11. TYPO3com voted on patch set 4 V +1 02/22/18, 05:52 Completed build in 07m 38s on Thu, 22 Feb, 06:52 AM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20013

  12. Benjamin Franzke uploaded patch set 5 02/22/18, 08:42

  13. TYPO3com voted on patch set 5 V +1 02/22/18, 08:50 Completed build in 07m 52s on Thu, 22 Feb, 09:50 AM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20014

  14. Oliver Klee commented on patch set 5 02/22/18, 12:53

    ViewModuleController.php:86

    $language probably should be $langaugeId or $languageUid.

    ViewModuleController.php:88

    What does $id refer to? Please let's make this variable name more specific.

    ViewModuleController.php:196

    Ditto for $languageUid/$languageId.
  15. Benjamin Franzke uploaded patch set 6 02/22/18, 14:47

  16. Benjamin Franzke commented on patch set 6 02/22/18, 14:51

    ViewModuleController.php:86 Reply

    We'll get naming clashes in some method bodies because $languageUid is altered once, then needed in it's original form. That will be quite hard to review with this change. I've therefore reverted to patchset 3 and will propose those changes in a separate patch (when this one is merged)
  17. Benjamin Franzke voted on patch set 6 V +1 CR +1 02/22/18, 14:51

  18. TYPO3com voted on patch set 6 V +1 02/22/18, 14:55 Completed build in 08m 19s on Thu, 22 Feb, 03:55 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20024

  19. Mathias Schreiber voted on patch set 6 V +1 CR +1 02/22/18, 18:20

  20. Frans Saris voted on patch set 6 V +2 CR +2 02/22/18, 18:49

  21. Frans Saris merged patch set 7 02/22/18, 18:49