55855[TASK] Unit tests: Do not rely on CacheManager instance
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Mathias Schreiber +1
-
Verified V +2
- Andreas Kienast +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 35
- typo3/sysext/backend/Tests/Unit/Controller/File/FileControllerTest.php+45 −40
- typo3/sysext/backend/Tests/Unit/Form/Element/InputDateTimeElementTest.php+8 −0
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectItemsTest.php+71 −8
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaSelectTreeItemsTest.php+9 −0
- typo3/sysext/backend/Tests/Unit/Form/NodeExpansion/FieldControlTest.php+9 −0
- typo3/sysext/core/Classes/Localization/LanguageStore.php+2 −1
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php1+1 −1
- typo3/sysext/core/Tests/Integrity/IntegrityTest.php1+3 −19
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+5 −0
- typo3/sysext/core/Tests/Unit/Imaging/IconRegistryTest.php+50 −35
- typo3/sysext/core/Tests/Unit/Imaging/IconTest.php+21 −3
- typo3/sysext/core/Tests/Unit/Localization/Parser/LocallangXmlParserTest.php+53 −52
- typo3/sysext/core/Tests/Unit/Localization/Parser/XliffParserTest.php+20 −31
- typo3/sysext/core/Tests/Unit/Localization/LocalesTest.php+3 −14
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+34 −12
- typo3/sysext/core/Tests/Unit/Resource/Filter/FileNameFilterTest.php+1 −0
- typo3/sysext/core/Tests/Unit/Resource/Utility/FileExtensionFilterTest.php+17 −49
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/TypoScriptParserTest.php+16 −4
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+4 −4
- typo3/sysext/core/Tests/Unit/Utility/RootlineUtilityTest.php+24 −23
Show 15 more files
- typo3/sysext/extbase/Tests/Unit/Core/BootstrapTest.php+3 −1
- typo3/sysext/extbase/Tests/Unit/Persistence/Generic/BackendTest.php+20 −9
- typo3/sysext/extbase/Tests/Unit/Persistence/RepositoryTest.php+5 −2
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php1+18 −19
- typo3/sysext/extensionmanager/Tests/Unit/Controller/UpdateFromTerControllerTest.php1deleted+0 −138
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+11 −8
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+11 −3
- typo3/sysext/frontend/Tests/Unit/Authentication/FrontendUserAuthenticationTest.php1+2 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+1 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+4 −0
- typo3/sysext/frontend/Tests/Unit/View/AdminPanelViewTest.php+20 −0
- typo3/sysext/install/Tests/Unit/Service/CoreUpdateServiceTest.php1+0 −13
- typo3/sysext/recordlist/Tests/UnitDeprecated/RecordList/AbstractDatabaseRecordListTest.php+9 −1
- typo3/sysext/saltedpasswords/Tests/Unit/Salt/Pbkdf2SaltTest.php1+72 −85
- composer.lock+5 −5
Review log 1013
-
Christian Kuhn uploaded patch set 1 02/21/18, 17:44
-
Christian Kuhn commented on patch set 1 02/21/18, 17:52
note: in a next step we can clean up the singleton backups within tests, but that will happen with an own patch and needs further preparation.FileWriter.php:171this avoids a notice.IntegrityTest.php:39this integrity test is obsolete now with the bootstrap cleaning up after itself.LocalizationUtilityTest.php:490that should have been a functional test if any, otherwise it instantiates much more than just the test class under test.UpdateFromTerControllerTest.php:23this test class did not add value: the tests mocked $planet, just to verify a single call is done. Unit testing on controller 'glue code' does not add value and could only be done in a useful way as functional or acceptance test to test the whole thing including dependencies.FrontendUserAuthenticationTest.php:257this is a drive-by patch that should stabilize this flacky test, depending on test order.CoreUpdateServiceTest.php:79this test does not give much benefit and is very hard to mock properly.Pbkdf2SaltTest.php:47this test was useless - and there is no xclassing in unit tests anyway. -
TYPO3com voted on patch set 1 V -1 02/21/18, 17:53 Completed build in 08m 29s on Wed, 21 Feb, 06:53 PM Test Summary: 6 of 31039 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19988
-
Christian Kuhn commented on patch set 1 02/21/18, 17:54
ah snap, forgot about the deprecated unit tests. -
Christian Kuhn uploaded patch set 2 02/21/18, 18:04
-
TYPO3com voted on patch set 2 V +1 02/21/18, 18:12 Completed build in 08m 06s on Wed, 21 Feb, 07:12 PM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19991
-
Christian Kuhn voted on patch set 2 CR -1 02/21/18, 18:46
-
Christian Kuhn uploaded patch set 3 02/21/18, 18:51
-
TYPO3com voted on patch set 3 V +1 02/21/18, 19:00 Completed build in 08m 18s on Wed, 21 Feb, 08:00 PM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19992
-
Mathias Schreiber voted on patch set 3 V +1 CR +1 02/21/18, 19:51
-
Andreas Kienast voted on patch set 3 V +1 02/21/18, 20:11
-
Andreas Kienast voted on patch set 3 V +2 CR +2 02/21/18, 20:23
-
Andreas Kienast merged patch set 4 02/21/18, 20:23