Review main Merged

55857[TASK] Remove additional GET variables for sys_preview links

Benni Mack CR +2 V +2 Easy +3 −32 updated 02/22/18, 19:38

Commit message

The possibility of EXT:workspaces to add additional GET variables to
preview links was dropped with TYPO3 6.0, instead linking to the full
workspace was enabled, also of using workspaces instead of versioning.

This info (a string of additional GET vars) is now removed from adding
through the workspaces Hook class, instead the link to the whole
workspace is generated, and identified via a ADMCMD md5-hash.

Review

  • Code review CR +2
    • Frans Saris +2
    • Mathias Schreiber +1
    • Wouter Wolters +1
  • Verified V +2
    • Frans Saris +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1113

  1. Benni Mack uploaded patch set 1 02/21/18, 19:56

  2. TYPO3com voted on patch set 1 V +1 02/21/18, 20:04 Completed build in 08m 19s on Wed, 21 Feb, 09:04 PM Test Summary: 30905 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-19999

  3. Benni Mack uploaded patch set 2 02/21/18, 20:25

  4. Wouter Wolters voted on patch set 2 CR +1 02/21/18, 20:30

  5. TYPO3com voted on patch set 2 V +1 02/21/18, 20:34 Completed build in 09m 04s on Wed, 21 Feb, 09:34 PM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20003

  6. Frans Saris commented on patch set 2 02/21/18, 22:14

    PreviewHook.php:65

    This comment can also be removed is it not?
  7. Benni Mack commented on patch set 2 02/22/18, 09:29

    PreviewHook.php:65 Reply

    The comment applies to the code below. For now it is kept (but the next patch will remove that code as well ;))
  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/22/18, 10:05

  9. Frans Saris commented on patch set 2 02/22/18, 17:41

    PreviewHook.php:65 Reply Unresolved

    ah, correct

    PreviewHook.php:325

    What about this part or the comment? This can also be removed now
  10. Frans Saris commented on patch set 2 02/22/18, 17:50

    Where is this link generated. It doesn't seem to be the "preview element" link in the workspace module

    PreviewHook.php:325 Reply

    And remove the default `null` value. Does that value make sense now?
  11. Frans Saris commented on patch set 2 V +1 02/22/18, 18:46

    ok, found one use of the preview url. The notification email after you add the `###PREVIEW_LINK###` marker to the template :) Waiting for reaction of Benni about the phpdoc comment
  12. Frans Saris commented on patch set 2 V +2 CR +2 02/22/18, 19:38

    Phpdoc will be adjusted in follow up patches in this area
  13. Frans Saris merged patch set 3 02/22/18, 19:38