55858[BUGFIX] Convert URLs to punycode
Commit message
Review
-
Code review CR +2
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 3448
Show 1523 earlier messages
-
Sybille Peters uploaded patch set 1 02/21/18, 20:17
-
TYPO3com voted on patch set 1 V -1 02/21/18, 20:17 Completed build in 15s on Wed, 21 Feb, 09:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20002
-
Georg Ringer commented on patch set 1 02/21/18, 20:19
ExternalLinktype.php:150single quotes -
Sybille Peters commented on patch set 1 02/21/18, 20:22
> Patch Set 1: > > (2 comments) You are fast. Thanks for your comments. This is a WIP. I will work on it tomorrow. -
Sybille Peters commented on patch set 1 CR -1 02/22/18, 08:33
ExternalLinktype.php:136Reply UnresolvedIt's probably good to think about which methods should be public when we tackle https://forge.typo3.org/issues/59502. So for now it doesn't. -
Sybille Peters commented on patch set 1 02/22/18, 08:40
ExternalLinktype.php:150ReplyAck -
Sybille Peters uploaded patch set 2 02/22/18, 10:30
-
TYPO3com voted on patch set 2 V +1 02/22/18, 10:39 Completed build in 08m 05s on Thu, 22 Feb, 11:39 AM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20018
-
Oliver Klee commented on patch set 2 CR -1 02/22/18, 12:50
ExternalLinktype.php:61$result is a string, not a boolean. So this should be: if ($result === '') {ExternalLinktype.php:62You'll need to define $errorParams first (or set the complete array).ExternalLinktype.php:195You can make this a guard clause: If ($url === '') { return ''; } -
Sybille Peters commented on patch set 2 02/22/18, 20:21
ExternalLinktype.php:61ReplyAckExternalLinktype.php:62ReplyAckExternalLinktype.php:195ReplyAck -
Sybille Peters uploaded patch set 3 02/22/18, 20:24
-
TYPO3com voted on patch set 3 V -1 02/22/18, 20:24 Completed build in 08s on Thu, 22 Feb, 09:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20030
-
Sybille Peters uploaded patch set 4 02/22/18, 21:11
-
TYPO3com voted on patch set 4 V -1 02/22/18, 21:11 Completed build in 10s on Thu, 22 Feb, 10:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20035
-
Sybille Peters uploaded patch set 5 02/22/18, 21:16
-
TYPO3com voted on patch set 5 V -1 02/22/18, 21:16 Completed build in 08s on Thu, 22 Feb, 10:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20036
-
Sybille Peters rebased onto patch set 6 02/22/18, 21:24
-
TYPO3com commented on patch set 6 02/22/18, 21:24 Completed build in 08s on Thu, 22 Feb, 10:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20037
-
Sybille Peters uploaded patch set 7 02/22/18, 21:29
-
TYPO3com voted on patch set 7 V -1 02/22/18, 21:37 Completed build in 07m 48s on Thu, 22 Feb, 10:37 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20038
-
Sybille Peters uploaded patch set 8 02/22/18, 22:05
-
TYPO3com voted on patch set 8 V +1 02/22/18, 22:14 Completed build in 08m 26s on Thu, 22 Feb, 11:14 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20040
-
Sybille Peters uploaded patch set 9 02/23/18, 12:38
-
TYPO3com voted on patch set 9 V +1 02/23/18, 12:47 Completed build in 08m 34s on Fri, 23 Feb, 01:47 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20063
-
Sybille Peters uploaded patch set 10 02/23/18, 13:24
-
TYPO3com voted on patch set 10 V -1 02/23/18, 13:35 Completed build in 11m 02s on Fri, 23 Feb, 02:35 PM Test Summary: 1 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20065
-
TYPO3com voted on patch set 10 V +1 02/23/18, 14:15 Completed build in 1h 01m 27s on Fri, 23 Feb, 03:15 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20065
-
Oliver Klee commented on patch set 10 02/23/18, 16:08
Except for the smaller polish things, the code looks very good. We should have unit tests for this, though.ExternalLinktype.php:60This comment does not seem to be needed (and also not part of this change).ExternalLinktype.php:157For consistency, please drop the blank line.ExternalLinktype.php:183Generally, the first sentence of a method comment should start with the third case so that the sentence with "This method" makes sense. In this case, I propose: "Converts the given URL to punycode in order to handle …" And also: ascii -> ASCII -
Oliver Klee commented on patch set 10 02/23/18, 16:08
urls -> URLs -
Sybille Peters commented on patch set 10 02/23/18, 16:21
> Patch Set 10: > > (3 comments) > > Except for the smaller polish things, the code looks very good. > > We should have unit tests for this, though. I would like to tackle tests with the next issue if that is ok with you, see https://forge.typo3.org/issues/83850Reply
Ack -
Sybille Peters commented on patch set 10 02/23/18, 16:34
Reply
AckExternalLinktype.php:60ReplyAckExternalLinktype.php:157ReplyAckExternalLinktype.php:183ReplyAck -
Sybille Peters uploaded patch set 11 02/23/18, 16:36
-
TYPO3com voted on patch set 11 V +1 02/23/18, 16:43 Completed build in 07m 26s on Fri, 23 Feb, 05:43 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20076
-
Michael Oehlhof commented on patch set 11 CR +1 02/23/18, 17:21
ExternalLinktype.php:180given -
Sybille Peters uploaded patch set 12 02/23/18, 18:34
-
TYPO3com voted on patch set 12 V +1 02/23/18, 18:44 Completed build in 09m 50s on Fri, 23 Feb, 07:44 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20079
-
Jörg Bösche voted on patch set 12 CR +1 02/26/18, 09:32
-
Steffen Frese voted on patch set 12 CR +1 03/06/18, 14:02
-
Mathias Schreiber voted on patch set 12 V +1 CR +1 03/07/18, 17:48
-
Christian Kuhn commented on patch set 12 CR -1 03/07/18, 22:55
will test and do a minor update.locallang.xlf:183i'd actually prefer to keep that name - not renaming the label key just gives a little less headaches on translation server.locallang.xlf:190whitespace detail ;) -
Christian Kuhn commented on patch set 12 03/07/18, 23:02
ExternalLinktype.php:104that's bogus since \InvalidArgumentException extends \Exception that is caught below with the same handle block. -
Christian Kuhn commented on patch set 12 03/07/18, 23:06
ExternalLinktype.php:153type = 'internal error' is never created in this class. -
Christian Kuhn uploaded patch set 13 03/07/18, 23:08
-
Christian Kuhn commented on patch set 13 V +1 CR +1 03/07/18, 23:08
reduced patch down to what is really needed, tested successfully. -
TYPO3com voted on patch set 13 V +1 03/07/18, 23:16 Completed build in 08m 10s on Thu, 8 Mar, 12:16 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20660
-
Andreas Kienast voted on patch set 13 V +2 CR +2 03/08/18, 08:51
-
Andreas Kienast merged patch set 14 03/08/18, 08:51
-
Andreas Kienast commented on patch set 14 03/08/18, 08:51
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 74f1009b6a3a436440d4333adeac35e0cc71eb23
ExternalLinktype.php:136