Review main Merged

55858[BUGFIX] Convert URLs to punycode

Sybille Peters CR +2 V +2 Easy +15 −3 updated 03/08/18, 08:51

Commit message

Review

  • Code review CR +2
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3448

Show 1523 earlier messages
  1. Sybille Peters uploaded patch set 1 02/21/18, 20:17

  2. TYPO3com voted on patch set 1 V -1 02/21/18, 20:17 Completed build in 15s on Wed, 21 Feb, 09:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20002

  3. Georg Ringer commented on patch set 1 02/21/18, 20:19

    ExternalLinktype.php:136

    does this need to be public? lets make $url always string and use a type hint

    ExternalLinktype.php:150

    single quotes
  4. Sybille Peters commented on patch set 1 02/21/18, 20:22

    > Patch Set 1: > > (2 comments) You are fast. Thanks for your comments. This is a WIP. I will work on it tomorrow.
  5. Sybille Peters commented on patch set 1 CR -1 02/22/18, 08:33

    ExternalLinktype.php:136 Reply Unresolved

    It's probably good to think about which methods should be public when we tackle https://forge.typo3.org/issues/59502. So for now it doesn't.
  6. Sybille Peters commented on patch set 1 02/22/18, 08:40

    ExternalLinktype.php:150 Reply

    Ack
  7. Sybille Peters uploaded patch set 2 02/22/18, 10:30

  8. TYPO3com voted on patch set 2 V +1 02/22/18, 10:39 Completed build in 08m 05s on Thu, 22 Feb, 11:39 AM Test Summary: 30887 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20018

  9. Oliver Klee commented on patch set 2 CR -1 02/22/18, 12:50

    ExternalLinktype.php:61

    $result is a string, not a boolean. So this should be: if ($result === '') {

    ExternalLinktype.php:62

    You'll need to define $errorParams first (or set the complete array).

    ExternalLinktype.php:195

    You can make this a guard clause: If ($url === '') { return ''; }
  10. Sybille Peters commented on patch set 2 02/22/18, 20:21

    ExternalLinktype.php:61 Reply

    Ack

    ExternalLinktype.php:62 Reply

    Ack

    ExternalLinktype.php:195 Reply

    Ack
  11. Sybille Peters uploaded patch set 3 02/22/18, 20:24

  12. TYPO3com voted on patch set 3 V -1 02/22/18, 20:24 Completed build in 08s on Thu, 22 Feb, 09:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20030

  13. Sybille Peters uploaded patch set 4 02/22/18, 21:11

  14. TYPO3com voted on patch set 4 V -1 02/22/18, 21:11 Completed build in 10s on Thu, 22 Feb, 10:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20035

  15. Sybille Peters uploaded patch set 5 02/22/18, 21:16

  16. TYPO3com voted on patch set 5 V -1 02/22/18, 21:16 Completed build in 08s on Thu, 22 Feb, 10:16 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20036

  17. Sybille Peters rebased onto patch set 6 02/22/18, 21:24

  18. TYPO3com commented on patch set 6 02/22/18, 21:24 Completed build in 08s on Thu, 22 Feb, 10:24 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20037

  19. Sybille Peters uploaded patch set 7 02/22/18, 21:29

  20. TYPO3com voted on patch set 7 V -1 02/22/18, 21:37 Completed build in 07m 48s on Thu, 22 Feb, 10:37 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20038

  21. Sybille Peters uploaded patch set 8 02/22/18, 22:05

  22. TYPO3com voted on patch set 8 V +1 02/22/18, 22:14 Completed build in 08m 26s on Thu, 22 Feb, 11:14 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20040

  23. Sybille Peters uploaded patch set 9 02/23/18, 12:38

  1. TYPO3com voted on patch set 9 V +1 02/23/18, 12:47 Completed build in 08m 34s on Fri, 23 Feb, 01:47 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20063

  2. Sybille Peters uploaded patch set 10 02/23/18, 13:24

  3. TYPO3com voted on patch set 10 V -1 02/23/18, 13:35 Completed build in 11m 02s on Fri, 23 Feb, 02:35 PM Test Summary: 1 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20065

  4. TYPO3com voted on patch set 10 V +1 02/23/18, 14:15 Completed build in 1h 01m 27s on Fri, 23 Feb, 03:15 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20065

  5. Oliver Klee commented on patch set 10 02/23/18, 16:08

    Except for the smaller polish things, the code looks very good. We should have unit tests for this, though.

    ExternalLinktype.php:60

    This comment does not seem to be needed (and also not part of this change).

    ExternalLinktype.php:157

    For consistency, please drop the blank line.

    ExternalLinktype.php:183

    Generally, the first sentence of a method comment should start with the third case so that the sentence with "This method" makes sense. In this case, I propose: "Converts the given URL to punycode in order to handle …" And also: ascii -> ASCII
  6. Oliver Klee commented on patch set 10 02/23/18, 16:08

    urls -> URLs
  7. Sybille Peters commented on patch set 10 02/23/18, 16:21

    > Patch Set 10: > > (3 comments) > > Except for the smaller polish things, the code looks very good. > > We should have unit tests for this, though. I would like to tackle tests with the next issue if that is ok with you, see https://forge.typo3.org/issues/83850

    Reply

    Ack
  8. Sybille Peters commented on patch set 10 02/23/18, 16:34

    Reply

    Ack

    ExternalLinktype.php:60 Reply

    Ack

    ExternalLinktype.php:157 Reply

    Ack

    ExternalLinktype.php:183 Reply

    Ack
  9. Sybille Peters uploaded patch set 11 02/23/18, 16:36

  10. TYPO3com voted on patch set 11 V +1 02/23/18, 16:43 Completed build in 07m 26s on Fri, 23 Feb, 05:43 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20076

  11. Michael Oehlhof commented on patch set 11 CR +1 02/23/18, 17:21

    ExternalLinktype.php:180

    given
  12. Sybille Peters uploaded patch set 12 02/23/18, 18:34

  13. TYPO3com voted on patch set 12 V +1 02/23/18, 18:44 Completed build in 09m 50s on Fri, 23 Feb, 07:44 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20079

  14. Jörg Bösche voted on patch set 12 CR +1 02/26/18, 09:32

  15. Steffen Frese voted on patch set 12 CR +1 03/06/18, 14:02

  16. Mathias Schreiber voted on patch set 12 V +1 CR +1 03/07/18, 17:48

  17. Christian Kuhn commented on patch set 12 CR -1 03/07/18, 22:55

    will test and do a minor update.

    locallang.xlf:183

    i'd actually prefer to keep that name - not renaming the label key just gives a little less headaches on translation server.

    locallang.xlf:190

    whitespace detail ;)
  18. Christian Kuhn commented on patch set 12 03/07/18, 23:02

    ExternalLinktype.php:104

    that's bogus since \InvalidArgumentException extends \Exception that is caught below with the same handle block.
  19. Christian Kuhn commented on patch set 12 03/07/18, 23:06

    ExternalLinktype.php:153

    type = 'internal error' is never created in this class.
  20. Christian Kuhn uploaded patch set 13 03/07/18, 23:08

  21. Christian Kuhn commented on patch set 13 V +1 CR +1 03/07/18, 23:08

    reduced patch down to what is really needed, tested successfully.
  22. TYPO3com voted on patch set 13 V +1 03/07/18, 23:16 Completed build in 08m 10s on Thu, 8 Mar, 12:16 AM Test Summary: 30819 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20660

  23. Andreas Kienast voted on patch set 13 V +2 CR +2 03/08/18, 08:51

  24. Andreas Kienast merged patch set 14 03/08/18, 08:51

  25. Andreas Kienast commented on patch set 14 03/08/18, 08:51

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 74f1009b6a3a436440d4333adeac35e0cc71eb23