Review main Merged

55867[TASK] Use PSR-7 request params in viewpage module

Benjamin Franzke CR +2 V +2 Normal +60 −58 updated 02/25/18, 21:28

Commit message

Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b
the viewpage module is a native PSR-7 controller, therefore
GeneralUtility _GP() and getIndpEnv() should no longer be used.

Restructure the code to use strict typing (to prevent type casting all
over the code), unify naming ($pageId and $languageId), and to prevent
calculating $targetUrl twice.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 68

  1. Benjamin Franzke uploaded patch set 1 02/22/18, 20:27

  2. TYPO3com voted on patch set 1 V +1 02/22/18, 20:35 Completed build in 08m 35s on Thu, 22 Feb, 09:35 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20032

  3. Benjamin Franzke uploaded patch set 2 02/22/18, 20:42

  4. TYPO3com voted on patch set 2 V +1 02/22/18, 20:50 Completed build in 07m 46s on Thu, 22 Feb, 09:50 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20033

  5. Benni Mack voted on patch set 2 CR +1 02/23/18, 20:14

  6. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/25/18, 21:13

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/25/18, 21:28

  8. Benni Mack merged patch set 3 02/25/18, 21:28