Review main Merged

55869[BUGFIX] Respect empty allowedMimeTypes for file uploads

Ralf Zimmermann CR +2 V +2 Easy +10 −3 updated 03/15/18, 21:08

Commit message

Make it possible to allow all mime types (except php) within file upload
form elements.
Since there are some default mime types configured within the ext:form
standard setup, you have to remove this default mime types within your
form definition (or reconfigure the default values within your custom
ext:form setup).

FileUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null
    3: null

ImageUpload:

properties:
  allowedMimeTypes:
    0: null
    1: null
    2: null

Review

  • Code review CR +2
    • Susi Moog +2
    • Tobi Kretschmann +1
    • Frank Nägler +1
    • Jörg Bösche +1
    • Steffen Frese +1
  • Verified V +2
    • Susi Moog +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1317

  1. Ralf Zimmermann uploaded patch set 1 02/22/18, 23:13

  2. TYPO3com voted on patch set 1 V -1 02/22/18, 23:23 Completed build in 09m 54s on Fri, 23 Feb, 12:23 AM Test Summary: 15 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20042

  3. Ralf Zimmermann uploaded patch set 2 02/22/18, 23:50

  4. TYPO3com voted on patch set 2 V +1 02/22/18, 23:59 Completed build in 08m 23s on Fri, 23 Feb, 12:59 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20046

  5. Jörg Bösche commented on patch set 2 CR -1 02/23/18, 08:18

    PropertyMappingConfiguration.php:65

    Can you remove the else case here and set the $validators = [] variable as default? Better reading and less complexity.
  6. Ralf Zimmermann uploaded patch set 3 02/23/18, 08:21

  7. Ralf Zimmermann commented on patch set 3 02/23/18, 08:22

    PropertyMappingConfiguration.php:65 Reply

    Ack
  8. Ralf Zimmermann uploaded patch set 4 02/23/18, 08:24

  9. TYPO3com voted on patch set 3 V +1 02/23/18, 08:31 Completed build in 09m 46s on Fri, 23 Feb, 09:31 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20048

  10. TYPO3com voted on patch set 4 V +1 02/23/18, 08:33 Completed build in 08m 59s on Fri, 23 Feb, 09:33 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20049

  11. Jörg Bösche voted on patch set 4 CR +1 02/23/18, 09:01

  12. Tobi Kretschmann voted on patch set 4 CR +1 02/28/18, 12:58

  13. Steffen Frese voted on patch set 4 CR +1 03/06/18, 13:58

  14. Susi Moog voted on patch set 4 V +1 CR +1 03/15/18, 21:07

  15. Frank Nägler voted on patch set 4 V +1 CR +1 03/15/18, 21:08

  16. Susi Moog voted on patch set 4 V +2 CR +2 03/15/18, 21:08

  17. Susi Moog merged patch set 5 03/15/18, 21:08