Review main Merged

55871[TASK] Remove unused workspace_preview DB field

Benni Mack CR +2 V +2 Easy +0 −18 updated 02/28/18, 11:25

Commit message

The unused BE_USER method setWorkspacePreview()
updates a DB field called "workspace_preview_id" which just
does not exist at all. It would lead to an SQL error if called.

However, since this method is never called, nor evaluated since TYPO3 6.2,
all functionality should be removed. Previewing a workspace is handled
via `be_users.workspace_id` anyway.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1220

  1. Benni Mack uploaded patch set 1 02/23/18, 10:24

  2. TYPO3com voted on patch set 1 V -1 02/23/18, 10:30 Completed build in 05m 39s on Fri, 23 Feb, 11:30 AM Test Summary: 1803 of 30961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20054

  3. Andreas Kienast commented on patch set 1 02/23/18, 10:32

    This need a pull request in the testing-framework, the fixtures still set < workspace_preview>.
  4. Benni Mack uploaded patch set 2 02/24/18, 10:32

  5. TYPO3com voted on patch set 2 V -1 02/24/18, 10:39 Completed build in 07m 11s on Sat, 24 Feb, 11:39 AM Test Summary: 1803 of 30961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20089

  6. Benni Mack uploaded patch set 3 02/24/18, 11:31

  7. TYPO3com voted on patch set 3 V -1 02/24/18, 11:37 Completed build in 05m 52s on Sat, 24 Feb, 12:37 PM Test Summary: 1803 of 30961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20091

  8. TYPO3com commented on patch set 3 02/27/18, 15:08 Completed build in 3h 43m 39s on Tue, 27 Feb, 04:08 PM Test Summary: 1803 of 30961 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20091

  9. Georg Ringer rebased onto patch set 4 02/27/18, 19:48

  10. TYPO3com voted on patch set 4 V -1 02/27/18, 19:57 Completed build in 09m 19s on Tue, 27 Feb, 08:57 PM Test Summary: 1803 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20242

  11. Georg Ringer commented on patch set 4 02/27/18, 20:25

  12. Christian Kuhn rebased onto patch set 5 02/28/18, 11:04

  13. Christian Kuhn commented on patch set 5 02/28/18, 11:05

    testing-framework has been raised meanwhile
  14. TYPO3com voted on patch set 5 V -1 02/28/18, 11:11 Completed build in 07m 03s on Wed, 28 Feb, 12:11 PM Test Summary: 1803 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20275

  15. Christian Kuhn updated the commit message in patch set 6 02/28/18, 11:14

  16. TYPO3com commented on patch set 5 02/28/18, 11:18 Completed build in 21m 27s on Wed, 28 Feb, 12:18 PM Test Summary: 1803 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20275

  17. Frank Nägler voted on patch set 6 V +1 CR +1 02/28/18, 11:25

  18. TYPO3com voted on patch set 6 V +1 02/28/18, 11:25 Completed build in 10m 45s on Wed, 28 Feb, 12:25 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20278

  19. Christian Kuhn voted on patch set 6 V +2 CR +2 02/28/18, 11:25

  20. Christian Kuhn merged patch set 7 02/28/18, 11:25