Review TYPO3_8-7 Merged

55884[BUGIFX] MediaceExtractionUpdate in Install Tool always requiring an update

Joshua Westerheide CR +2 V +2 Easy +1 −1 updated 03/05/18, 19:11

Commit message

Due to recent refactoring to use the Doctrine Query Builder the
`checkForUpdate()` method of MediaceExtractionUpdate broke.
`\Doctrine\DBAL\Driver\ResultStatement::fetchColumn` may return
a string depending on used db driver.

Fixes changes made by I77dd213b75acbb129954ccdcf70a3722bf1a6675.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Wouter Wolters +1
  • Verified V +2
    • Christian Kuhn +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1417

  1. Joshua Westerheide uploaded patch set 1 02/24/18, 10:38

  2. Joshua Westerheide wrote 02/24/18, 10:41

    Topic set to Install Tool
  3. Joshua Westerheide updated the commit message in patch set 2 02/24/18, 10:43

  4. TYPO3com voted on patch set 1 V +1 02/24/18, 10:56 Completed build in 17m 34s on Sat, 24 Feb, 11:56 AM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1944

  5. TYPO3com voted on patch set 2 V +1 02/24/18, 10:57 Completed build in 13m 57s on Sat, 24 Feb, 11:57 AM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1945

  6. Wouter Wolters commented on patch set 2 02/24/18, 13:00

    Is master also affected?
  7. Joshua Westerheide commented on patch set 2 02/24/18, 14:06

    > Patch Set 2: > > Is master also affected? No, the test has been removed after TYPO3 8.7. Please also notice https://forge.typo3.org/issues/83508.
  8. Wouter Wolters voted on patch set 2 V +1 CR +1 03/02/18, 12:30

  9. Christian Kuhn commented on patch set 2 CR -1 03/05/18, 13:55

    it depends on the given db driver if the return value is a string or an integer. for instance, with mysqli int is returned, with pdo_mysql a string. i'll change the test to an (int) cast on the value.
  10. Christian Kuhn uploaded patch set 3 03/05/18, 13:57

  11. Christian Kuhn voted on patch set 3 V +1 CR +1 03/05/18, 13:58

  12. TYPO3com voted on patch set 3 V +1 03/05/18, 14:07 Completed build in 09m 19s on Mon, 5 Mar, 03:07 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2005

  13. Joshua Westerheide commented on patch set 3 03/05/18, 14:14

    > it depends on the given db driver if the return value is a string > or an integer. for instance, with mysqli int is returned, with > pdo_mysql a string. i'll change the test to an (int) cast on the > value. But when casting to an int > it depends on the given db driver if the return value is a string > or an integer. for instance, with mysqli int is returned, with > pdo_mysql a string. i'll change the test to an (int) cast on the > value. Under some circumstances, if the result returns nothing, somehow, the MysqliStatement might return `null` which would be casted to a 0. Do you want to catch this case? Another solution would be to set the default fetch mode to `\PDO::FETCH_NUM`. The `MysqliStatement` already ignores it and enforces the INT fetch mode but the `PDOStatement` doesn't yet. Then you could rely on the strong type check.
  14. Christian Kuhn commented on patch set 3 03/05/18, 14:39

    thanks for further input on this, Joshua. i think the int cast is ok for now: null would lead to not show the wizard too, which is what we want here. since that is a bugfix for 8.7 "only", i'd also refrain from fiddling with FETCH_NUM and others since that would need more excessive tests if eg. postgres does what we want. the patch should be safe in it's current form, the solution is already used at other core places, too.
  15. Wouter Wolters voted on patch set 3 V +1 CR +1 03/05/18, 14:47

  16. Christian Kuhn voted on patch set 3 V +2 CR +2 03/05/18, 19:11

  17. Christian Kuhn merged patch set 4 03/05/18, 19:11