Review main Merged

55886[TASK] Move evaluation of ADMCMD_noBeUser to workspace hook

Benni Mack CR +2 V +2 Easy +14 −7 updated 02/24/18, 17:20

Commit message

The GET parameter "ADMCMD_noBeUser" is handed over to the frontend
when a workspace preview is shown, in comparison to a live version.

In order to render the "live version", the GET parameter "ADMCMD_noBeUser"
is set, and resets BE User permisisons and preview infos.

This can be simplified in the PreviewHook to ensure that the live
version without a Backend User is used.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 45

  1. Benni Mack uploaded patch set 1 02/24/18, 11:46

  2. TYPO3com voted on patch set 1 V +1 02/24/18, 11:54 Completed build in 07m 59s on Sat, 24 Feb, 12:54 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20092

  3. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/24/18, 17:17

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/24/18, 17:20

  5. Benni Mack merged patch set 2 02/24/18, 17:20