Review main Merged

55887[TASK] Get rid of special fePreview=2 for workspaces

Benni Mack CR +2 V +2 Easy +6 −9 updated 02/25/18, 20:52

Commit message

If a workspace is being previewed, the check does not have a kasper'sche boolean
value (0,1,2) anymore, as the detection of a workspace is handled via a
separate method $this->doWorkspacePreview() anyways.

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Oliver Hader +1
    • Susi Moog +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 811

  1. Benni Mack uploaded patch set 1 02/24/18, 17:30

  2. TYPO3com voted on patch set 1 V -1 02/24/18, 17:40 Completed build in 09m 49s on Sat, 24 Feb, 06:40 PM Test Summary: 219 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20094

  3. TYPO3com commented on patch set 1 02/24/18, 19:49 Completed build in 2h 29m 04s on Sat, 24 Feb, 08:49 PM Test Summary: 219 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20094

  4. Susi Moog commented on patch set 1 02/25/18, 19:38

    TypoScriptFrontendController.php:1273 Unresolved

    this change kills the tests...
  5. Benni Mack uploaded patch set 2 02/25/18, 20:28

  6. TYPO3com voted on patch set 2 V +1 02/25/18, 20:36 Completed build in 08m 09s on Sun, 25 Feb, 09:36 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20119

  7. Oliver Hader voted on patch set 2 CR +1 02/25/18, 20:40

  8. Susi Moog voted on patch set 2 V +1 CR +1 02/25/18, 20:44

  9. Mathias Schreiber voted on patch set 2 V +1 CR +1 02/25/18, 20:52

  10. Benni Mack voted on patch set 2 V +2 CR +2 02/25/18, 20:52

  11. Benni Mack merged patch set 3 02/25/18, 20:52