Review main Merged

55888[TASK] Move workspace preview user to custom class

Benni Mack CR +2 V +2 Normal +119 −118 updated 09/12/20, 20:37

Commit message

Instead of faking an existing backend user, the workspace preview
functionality (= from a link) should use an anonymous read-only
use which has only access to the workspace and the page, in order
to remove the hacks to allow read-access for existing backend users.

This way, the hook code is getting cleaner and easier to read, and also
easier to debug.

Review

  • Code review CR +2
    • Benni Mack +2
  • Verified V +2
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1016

  1. Benni Mack uploaded patch set 1 02/24/18, 20:03

  2. TYPO3com voted on patch set 1 V +1 02/24/18, 20:12 Completed build in 08m 30s on Sat, 24 Feb, 09:12 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20097

  3. Benni Mack uploaded patch set 2 02/25/18, 21:38

  4. Benni Mack uploaded patch set 3 02/25/18, 21:39

  5. TYPO3com voted on patch set 3 V -1 02/25/18, 21:39 Completed build in 10s on Sun, 25 Feb, 10:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20126

  6. Benni Mack uploaded patch set 4 02/25/18, 21:45

  7. TYPO3com voted on patch set 2 V +1 02/25/18, 21:47 Completed build in 09m 01s on Sun, 25 Feb, 10:47 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20125

  8. Benni Mack uploaded patch set 5 02/25/18, 21:51

  9. TYPO3com voted on patch set 4 V +1 02/25/18, 21:55 Completed build in 09m 51s on Sun, 25 Feb, 10:55 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20127

  10. TYPO3com voted on patch set 5 V -1 02/25/18, 22:01 Completed build in 09m 18s on Sun, 25 Feb, 11:01 PM Test Summary: 1 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20128

  11. TYPO3com voted on patch set 5 V +1 02/25/18, 22:09 Completed build in 26m 56s on Sun, 25 Feb, 11:09 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20128

  12. Benni Mack voted on patch set 5 V +2 CR +2 02/26/18, 05:24

  13. Benni Mack merged patch set 6 02/26/18, 05:25

  14. Andreas Kienast commented on patch set 6 02/26/18, 07:23

    PreviewUserAuthentication.php:94 Unresolved

    Does this work? IIRC $perms is a bitmask.
  15. Alexander Opitz commented on patch set 6 04/09/20, 17:31

    This patch is Breaking! But it isn't marked as such and it do not include a .rst file about this hard change. As PreviewUserAuthentication extends from BackendUserAuthentication and not from FrontendBackendUserAuthentication it had to implement all functions from FrontendBackendUserAuthentication including the deprecated ones (as they will be removed in 10 not earlier). That change brakes for example extensions (like TV+) which need to check for activation of frontend editing.
  16. Benni Mack commented on patch set 6 09/12/20, 20:37

    > Patch Set 6: > > This patch is Breaking! But it isn't marked as such and it do not include a .rst file about this hard change. > > As PreviewUserAuthentication extends from BackendUserAuthentication and not from FrontendBackendUserAuthentication it had to implement all functions from FrontendBackendUserAuthentication including the deprecated ones (as they will be removed in 10 not earlier). That change brakes for example extensions (like TV+) which need to check for activation of frontend editing. Thanks Alex, for the feedback. I see your point and did not see this back then, but that's over 2 years ago. If there is anything we can improve in current versions and you have concrete suggestions, could you open up a follow up issue?