Review main Merged

55895[TASK] Use TSFE API methods for checking workspace preview

Benni Mack CR +2 V +2 Easy +6 −25 updated 02/25/18, 21:34

Commit message

Instead of using the public "workspacePreview" parameter in TSFE,
which is only set when a sys_preview keyword is used, the parameter
from the BE User can be used instead directly (which is used anyways
when using the API methods TSFE->whichWorkspace()).

The TSFE method doWorkspacePreview() is adapted accordingly to be in line
with the rest of the code.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • Oliver Hader +1
  • Verified V +2
    • Wouter Wolters +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Benni Mack uploaded patch set 1 02/25/18, 21:08

  2. TYPO3com voted on patch set 1 V +1 02/25/18, 21:15 Completed build in 07m 53s on Sun, 25 Feb, 10:15 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20121

  3. Oliver Hader commented on patch set 1 CR +1 02/25/18, 21:19

    TypoScriptFrontendController.php:230

    Still add @deprecated (since v10 then)?
  4. Tymoteusz Motylewski commented on patch set 1 02/25/18, 21:21

    TypoScriptFrontendController.php:230

    Shouldnt we remove it or deprecate at last?
  5. Mathias Schreiber voted on patch set 1 V +1 CR +1 02/25/18, 21:21

  6. Benni Mack commented on patch set 1 02/25/18, 21:22

    TypoScriptFrontendController.php:230 Reply

    will do separately, as we can probably deprecate $TSFE->doWorkspacePreview() as well in a few weeks.
  7. Wouter Wolters voted on patch set 1 V +2 CR +2 02/25/18, 21:34

  8. Wouter Wolters merged patch set 2 02/25/18, 21:34