55896[BUGFIX] Make sure that mass actions actually process all changes
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
-
Verified V +2
- Christian Kuhn +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 58
-
Benedikt Huss uploaded patch set 1 02/25/18, 21:45
-
TYPO3com voted on patch set 1 V +1 02/25/18, 22:01 Completed build in 15m 23s on Sun, 25 Feb, 11:01 PM Test Summary: 58119 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1948
-
Anja Leichsenring commented on patch set 1 CR -1 02/28/18, 07:56
Hi Benedikt, I see this is your first patch, thank you very much for taking things in your own hands. My -1 is not to your code, only a formality you did probably not know, so please bear with me. You stated that this patch should go into master and 8.7, but you pushed to 8.7. We patch bottom down, so each issue will be fixed in master first, then backported. This cuts short on double work, when the initial patch receives changes during the review. So in order to do things in the right way, I kindly ask you to push this very patch with the very same commit message, especially the Change-Id must not change, to the master branch and make sure it applies there (both code and functionality wise). Then the team will review that master patch, and once it gets merged, the Core Team member merging will take care of the backport. Thank you for your understanding, and please keep up the good work! Kind regards Anja -
Christian Kuhn uploaded patch set 2 02/28/18, 11:37
-
TYPO3com voted on patch set 2 V -1 02/28/18, 11:51 Completed build in 14m 01s on Wed, 28 Feb, 12:51 PM Test Summary: 1 of 58463 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1961
-
TYPO3com voted on patch set 2 V +1 02/28/18, 12:11 Completed build in 47m 37s on Wed, 28 Feb, 01:11 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1961
-
Christian Kuhn voted on patch set 2 V +2 CR +2 02/28/18, 12:12
-
Christian Kuhn merged patch set 3 02/28/18, 12:12