Review main Merged

55900[TASK] Clean up user permission checking in FE request handling

Benni Mack CR +2 V +2 Easy +8 −9 updated 02/26/18, 09:34

Commit message

The PHP code for checking if a backend user is allowed to preview
a page should use the Permission bitmask.

Additionally, the check extPageReadAccess() is a sub-method
of FrontendBackendUserAuthentication object, which checks the webmount
and the page permissions, however, "doesUserHaveAccess" also
checks for the webmount availability.

Review

  • Code review CR +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Andreas Kienast +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 56

  1. Benni Mack uploaded patch set 1 02/26/18, 06:56

  2. TYPO3com voted on patch set 1 V +1 02/26/18, 07:04 Completed build in 07m 56s on Mon, 26 Feb, 08:04 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20133

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 02/26/18, 07:33

  4. Jörg Bösche voted on patch set 1 V +1 CR +1 02/26/18, 09:25

  5. Benni Mack voted on patch set 1 V +2 CR +2 02/26/18, 09:34

  6. Benni Mack merged patch set 2 02/26/18, 09:34