Review main Merged

55901[TASK] Call getDomainStartPage without third parameter

Benni Mack CR +2 V +2 Easy +2 −2 updated 02/26/18, 11:58

Commit message

The third parameter in PageRepository->getDomainStartPage
is not used anymore. Saving an extra call to GeneralUtility
to not hand this parameter over to the method in TSFE should be helpful.

However, in the future, this method will probably be changed,
the third parameter is not deprecated for now.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • Jörg Bösche +1
  • Verified V +2
    • Frank Nägler +2
    • Wouter Wolters +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Benni Mack uploaded patch set 1 02/26/18, 08:40

  2. TYPO3com voted on patch set 1 V +1 02/26/18, 08:50 Completed build in 10m 18s on Mon, 26 Feb, 09:50 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20137

  3. Jörg Bösche voted on patch set 1 CR +1 02/26/18, 09:03

  4. Wouter Wolters voted on patch set 1 V +1 CR +1 02/26/18, 10:03

  5. Frank Nägler voted on patch set 1 V +2 CR +2 02/26/18, 11:57

  6. Frank Nägler merged patch set 2 02/26/18, 11:58