Review main Merged

55904[BUGFIX] Prevent duplicating icons definition in the page tree

Paweł Rogowicz CR +2 V +2 Easy +11 −3 updated 03/09/18, 15:11

Commit message

Additionally add a console warning when doktype doesn't have an icon

Review

  • Code review CR +2
    • Tymoteusz Motylewski +2
    • Mathias Schreiber +1
    • Josef Glatz +1
    • Andreas Kienast +1
  • Verified V +2
    • Tymoteusz Motylewski +2
    • Mathias Schreiber +1
    • Josef Glatz +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Paweł Rogowicz uploaded patch set 1 02/26/18, 12:57

  2. TYPO3com voted on patch set 1 V +1 02/26/18, 13:08 Completed build in 10m 44s on Mon, 26 Feb, 02:08 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20148

  3. Paweł Rogowicz uploaded patch set 2 02/26/18, 14:22

  4. Tymoteusz Motylewski voted on patch set 2 V +1 CR +1 02/26/18, 14:25

  5. Tymoteusz Motylewski updated the commit message in patch set 3 02/26/18, 14:31

  6. TYPO3com voted on patch set 2 V +1 02/26/18, 14:31 Completed build in 09m 30s on Mon, 26 Feb, 03:31 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20153

  7. Tymoteusz Motylewski commented on patch set 3 V +1 CR +1 02/26/18, 14:31

    for v8 manual backport is needed (just SvgTree part) I can take care of it.
  8. TYPO3com voted on patch set 3 V +1 02/26/18, 14:39 Completed build in 07m 58s on Mon, 26 Feb, 03:39 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20155

  9. Josef Glatz commented on patch set 3 V -1 02/26/18, 14:39

    On it
  10. Josef Glatz commented on patch set 3 V +1 CR +1 02/26/18, 15:18

    The duplicate-thing seems to be fixed!
  11. Mathias Schreiber voted on patch set 3 V +1 CR +1 02/26/18, 15:22

  12. Andreas Kienast voted on patch set 3 CR +1 02/26/18, 15:45

  13. Tymoteusz Motylewski voted on patch set 3 V +2 CR +2 02/26/18, 16:07

  14. Tymoteusz Motylewski merged patch set 4 02/26/18, 16:08

  15. Stephan Großberndt commented on patch set 4 03/09/18, 15:11

    Backport to 8.7 is missing