Review main Merged

55909[BUGFIX] Declare arguments 3 - 5 in Icons.getIcon() as optional

Andreas Kienast CR +2 V +2 Easy +3 −3 updated 02/26/18, 19:25

Commit message

The arguments `overlayIdentifier`, `state` and `markupIdentifier` are
not required most times. This patch declares these arguments as optional.

Review

  • Code review CR +2
    • Frank Nägler +2
  • Verified V +2
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Andreas Kienast uploaded patch set 1 02/26/18, 19:15

  2. Andreas Kienast wrote 02/26/18, 19:16

    Topic set to typescript
  3. TYPO3com voted on patch set 1 V +1 02/26/18, 19:23 Completed build in 08m 35s on Mon, 26 Feb, 08:23 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20169

  4. Frank Nägler voted on patch set 1 V +2 CR +2 02/26/18, 19:25

  5. Frank Nägler merged patch set 2 02/26/18, 19:25