Review main Merged

55913[TASK] Move preview setting evaluation in separate method

Benni Mack CR +2 V +2 Normal +70 −54 updated 07/05/19, 16:20

Commit message

The TSFE method "determineId" is hard to read, mostly due to
the fact that it first evaluates preview settings from admin panel
or logged-in backend users, and then calls "fetch_the_id()" possibly
multiple times.

In order to increase readability, the preview settings evaluation
is moved into a custom protected method within TSFE.

Review

  • Code review CR +2
    • Susi Moog +2
    • Stefan Neufeind +1
    • Georg Ringer +1
  • Verified V +2
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Benni Mack uploaded patch set 1 02/27/18, 06:15

  2. TYPO3com voted on patch set 1 V +1 02/27/18, 06:24 Completed build in 08m 42s on Tue, 27 Feb, 07:24 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20193

  3. Stefan Neufeind voted on patch set 1 CR +1 02/27/18, 08:32

  4. Georg Ringer voted on patch set 1 V +1 CR +1 02/27/18, 19:33

  5. Susi Moog voted on patch set 1 V +2 CR +2 02/28/18, 07:54

  6. Susi Moog merged patch set 2 02/28/18, 07:54

  7. Daniel Goerz commented on patch set 2 07/05/19, 16:20

    Could you have a look at this related patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61192