Review main Merged

55915[TASK] Streamline PHP assignments and comments

Benni Mack CR +2 V +2 Easy +13 −17 updated 02/27/18, 08:24

Commit message

Use shortening parameters on places that haven't been touched in a while
since PHP 7.0 was a requirement.

Fix PHPdoc comments on various places.

Use booleans instead of integers on variables clearly defined and evaluated
as booleans.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Jörg Bösche +1
  • Verified V +2
    • Georg Ringer +2
    • Andreas Kienast +1
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 56

  1. Benni Mack uploaded patch set 1 02/27/18, 06:54

  2. TYPO3com voted on patch set 1 V +1 02/27/18, 07:03 Completed build in 09m 22s on Tue, 27 Feb, 08:03 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20197

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 02/27/18, 07:27

  4. Jörg Bösche voted on patch set 1 V +1 CR +1 02/27/18, 08:10

  5. Georg Ringer voted on patch set 1 V +2 CR +2 02/27/18, 08:24

  6. Georg Ringer merged patch set 2 02/27/18, 08:24