Review main Merged Breaking

55916[!!!][BUGFIX] Allow browser notifications only on encrypted connection

Frank Nägler CR +2 V +2 Easy +38 −2 updated 02/28/18, 16:28

Commit message

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Sascha Egerer +1
  • Verified V +2
    • Christian Kuhn +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Sascha Egerer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1824

  1. Frank Nägler uploaded patch set 1 02/27/18, 09:36

  2. Mathias Brodala updated the commit message in patch set 2 02/27/18, 09:40

  3. Mathias Brodala commented on patch set 3 02/27/18, 09:43

    Published edit on patch set 2.
  4. TYPO3com voted on patch set 1 V -1 02/27/18, 09:45 Completed build in 08m 33s on Tue, 27 Feb, 10:45 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20202

  5. TYPO3com voted on patch set 2 V -1 02/27/18, 09:51 Completed build in 10m 36s on Tue, 27 Feb, 10:51 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20203

  6. Andreas Kienast voted on patch set 3 CR +1 02/27/18, 09:51

  7. TYPO3com voted on patch set 3 V -1 02/27/18, 09:52 Completed build in 08m 58s on Tue, 27 Feb, 10:52 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20204

  8. Benni Mack commented on patch set 3 02/27/18, 10:22

    I don't see this really breaking... if your (IE9) browser does not support notifications before, we did not consider this as well.
  9. Frank Nägler commented on patch set 3 02/27/18, 10:45

    But it worked without SSL support before.
  10. Frank Nägler uploaded patch set 4 02/27/18, 10:48

  11. Frank Nägler uploaded patch set 5 02/27/18, 10:50

  12. Frank Nägler commented on patch set 5 02/27/18, 10:52

    re-pushed patchset 3, sry for override it
  13. Frank Nägler commented on patch set 6 02/27/18, 10:53

    Published edit on patch set 5.
  14. TYPO3com voted on patch set 4 V -1 02/27/18, 10:58 Completed build in 10m 09s on Tue, 27 Feb, 11:58 AM Test Summary: 1 of 31033 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20206

  15. TYPO3com commented on patch set 5 02/27/18, 10:58 Completed build in 08m 36s on Tue, 27 Feb, 11:58 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20207

  16. TYPO3com voted on patch set 6 V +1 02/27/18, 11:03 Completed build in 09m 48s on Tue, 27 Feb, 12:03 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20208

  17. Georg Ringer voted on patch set 6 V +1 CR +1 02/27/18, 19:51

  18. Sascha Egerer voted on patch set 6 V +1 CR +1 02/27/18, 21:06

  19. Josef Glatz commented on patch set 6 V -1 02/28/18, 04:29

    Maybe we can improve it slightly? (see my comment on the RsT)

    Breaking-83971-ConsoleShowDeprecationWarningInChrome.rst:27

    # What about local development environments? You don't get any information if the session expires. That also implies, that everybody needs https support for local development (if it's not `http://localhost`), to test the modal box, or getting any feedback. ## Some ideas: - What about adding an alternative console message? - What about referencing the section of the [google link](https://sites.google.com/a/chromium.org/dev/Home/chromium-security/deprecating-powerful-features-on-insecure-origins#TOC-Testing-Powerful-Features) in the "Affected Installations" section of the RST or (maybe better) adding the part directly in the RST instead of only linking it
  20. Josef Glatz voted on patch set 6 V 0 CR -1 02/28/18, 04:37

  21. Frank Nägler commented on patch set 6 02/28/18, 08:28

    Breaking-83971-ConsoleShowDeprecationWarningInChrome.rst:27 Reply

    hmm, I am very not sure if it is worth. Some thoughts for local development: 1. Since about one year all my local dev systems running with SSL 2. My local dev systems never expire, the timeout is set to 1year+ 3. http;//localhost will be accepted, ok maybe this could be catched, but... my local setups are never localhost, it is something like http://foo.local or http://foo.dev or http://foo.bar.devbox.bla.de So., how many people really work with localhost? I have no idea. 4. adding a console message which prevent another console message? really? :D Sry, but this sounds funny to me. regarding the changes in the rst file I am fine, please feel free to change anything you like.
  22. Josef Glatz commented on patch set 6 V +1 CR +1 02/28/18, 16:23

    > Patch Set 6: > > (1 comment) Hey Frank, I just wanted to make sure if something is missing here. For me it's totally fine. I just thought about newcomers and not so savvy people. If somebody reads the RsT it should be enough!
  23. Christian Kuhn voted on patch set 6 V +2 CR +2 02/28/18, 16:28

  24. Christian Kuhn merged patch set 7 02/28/18, 16:28