55921[TASK] Update jQuery 3.2.1 ❯ 3.3.1
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 9
- Build/Gruntfile.js+2 −2
- Build/yarn.lock+5 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+2 −2
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery-3.2.1.min.jsdeleted+0 −4
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery.jsrenamed+455 −344
- typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery.min.jsnew+2 −0
- typo3/sysext/core/Tests/Functional/Page/PageRendererTest.php+5 −5
- typo3/sysext/install/Resources/Public/JavaScript/RequireJSConfig.js+1 −1
- composer.lock+5 −5
Review log 1726
Show 1 earlier messages
-
Frank Nägler uploaded patch set 1 02/27/18, 12:10
-
Frank Nägler wrote 02/27/18, 12:11
Topic set to yarn:update:02-2018 -
Frank Nägler uploaded patch set 2 02/27/18, 12:13
-
TYPO3com voted on patch set 1 V -1 02/27/18, 12:20 Completed build in 09m 19s on Tue, 27 Feb, 01:20 PM Test Summary: 30810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20214
-
TYPO3com voted on patch set 2 V -1 02/27/18, 12:23 Completed build in 10m 12s on Tue, 27 Feb, 01:23 PM Test Summary: 30810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20215
-
Stefan Neufeind commented on patch set 2 02/27/18, 13:07
bamboo says: 27-Feb-2018 13:15:05 PhantomJS 2.1.1 (Linux 0.0.0) ERROR 27-Feb-2018 13:15:05 ReferenceError: Can't find variable: jQuery 27-Feb-2018 13:15:05 at vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/Bootstrap.js:53 Could it be that's because jquery 3.2.1 is referenced from the testing-framework? vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/karma.conf.js -
Frank Nägler commented on patch set 2 02/27/18, 13:26
yes, looks like this is the problem -
Stefan Neufeind commented on patch set 2 02/27/18, 13:40
according to the other entries in the testing-framework I wonder if we can simply replace the version-number with a wildcard -
Frank Nägler uploaded patch set 3 02/27/18, 14:57
-
TYPO3com voted on patch set 3 V -1 02/27/18, 15:06 Completed build in 09m 20s on Tue, 27 Feb, 04:06 PM Test Summary: 61 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20221
-
TYPO3com commented on patch set 3 02/27/18, 15:10 Completed build in 22m 24s on Tue, 27 Feb, 04:10 PM Test Summary: 61 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20221
-
Frank Nägler uploaded patch set 4 02/28/18, 09:02
-
TYPO3com voted on patch set 4 V -1 02/28/18, 09:10 Completed build in 08m 19s on Wed, 28 Feb, 10:10 AM Test Summary: 61 of 30959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20263
-
Christian Kuhn uploaded patch set 5 02/28/18, 10:30
-
Andreas Kienast commented on patch set 5 V -1 02/28/18, 10:32
Backend tries to load typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery-3.3.1.js, which fails with a 404. -
Christian Kuhn commented on patch set 5 CR -1 02/28/18, 10:34
frank is on it. -
Frank Nägler uploaded patch set 6 02/28/18, 10:38
-
TYPO3com voted on patch set 5 V -1 02/28/18, 10:41 Completed build in 10m 19s on Wed, 28 Feb, 11:41 AM Test Summary: 61 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20272
-
Andreas Kienast voted on patch set 6 V +1 CR +1 02/28/18, 10:42
-
TYPO3com voted on patch set 6 V -1 02/28/18, 10:45 Completed build in 07m 48s on Wed, 28 Feb, 11:45 AM Test Summary: 12 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20273
-
Frank Nägler uploaded patch set 7 02/28/18, 10:48
-
Andreas Kienast voted on patch set 7 V +1 CR +1 02/28/18, 10:53
-
TYPO3com voted on patch set 7 V -1 02/28/18, 10:56 Completed build in 08m 12s on Wed, 28 Feb, 11:56 AM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20274
-
TYPO3com voted on patch set 7 V +1 02/28/18, 11:02 Completed build in 22m 35s on Wed, 28 Feb, 12:02 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20274
-
Christian Kuhn voted on patch set 7 V +2 CR +2 02/28/18, 11:03
-
Christian Kuhn merged patch set 8 02/28/18, 11:03