Review main Merged

55921[TASK] Update jQuery 3.2.1 ❯ 3.3.1

Frank Nägler CR +2 V +2 Hard +477 −364 updated 02/28/18, 11:03

Commit message

Needs a typo3/testing-framework raise, too.

Commands:
yarn upgrade jquery
composer update typo3/testing-framework

Updates:
- jquery@3.3.1

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2
    • Christian Kuhn +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1726

Show 1 earlier messages
  1. Frank Nägler uploaded patch set 1 02/27/18, 12:10

  1. Frank Nägler wrote 02/27/18, 12:11

    Topic set to yarn:update:02-2018
  2. Frank Nägler uploaded patch set 2 02/27/18, 12:13

  3. TYPO3com voted on patch set 1 V -1 02/27/18, 12:20 Completed build in 09m 19s on Tue, 27 Feb, 01:20 PM Test Summary: 30810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20214

  4. TYPO3com voted on patch set 2 V -1 02/27/18, 12:23 Completed build in 10m 12s on Tue, 27 Feb, 01:23 PM Test Summary: 30810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20215

  5. Stefan Neufeind commented on patch set 2 02/27/18, 13:07

    bamboo says: 27-Feb-2018 13:15:05 PhantomJS 2.1.1 (Linux 0.0.0) ERROR 27-Feb-2018 13:15:05 ReferenceError: Can't find variable: jQuery 27-Feb-2018 13:15:05 at vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/Bootstrap.js:53 Could it be that's because jquery 3.2.1 is referenced from the testing-framework? vendor/typo3/testing-framework/Resources/Core/Build/Configuration/JSUnit/karma.conf.js
  6. Frank Nägler commented on patch set 2 02/27/18, 13:26

    yes, looks like this is the problem
  7. Stefan Neufeind commented on patch set 2 02/27/18, 13:40

    according to the other entries in the testing-framework I wonder if we can simply replace the version-number with a wildcard
  8. Frank Nägler uploaded patch set 3 02/27/18, 14:57

  9. TYPO3com voted on patch set 3 V -1 02/27/18, 15:06 Completed build in 09m 20s on Tue, 27 Feb, 04:06 PM Test Summary: 61 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20221

  10. TYPO3com commented on patch set 3 02/27/18, 15:10 Completed build in 22m 24s on Tue, 27 Feb, 04:10 PM Test Summary: 61 of 30960 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20221

  11. Frank Nägler uploaded patch set 4 02/28/18, 09:02

  12. TYPO3com voted on patch set 4 V -1 02/28/18, 09:10 Completed build in 08m 19s on Wed, 28 Feb, 10:10 AM Test Summary: 61 of 30959 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20263

  13. Christian Kuhn uploaded patch set 5 02/28/18, 10:30

  14. Andreas Kienast commented on patch set 5 V -1 02/28/18, 10:32

    Backend tries to load typo3/sysext/core/Resources/Public/JavaScript/Contrib/jquery/jquery-3.3.1.js, which fails with a 404.
  15. Christian Kuhn commented on patch set 5 CR -1 02/28/18, 10:34

    frank is on it.
  16. Frank Nägler uploaded patch set 6 02/28/18, 10:38

  17. TYPO3com voted on patch set 5 V -1 02/28/18, 10:41 Completed build in 10m 19s on Wed, 28 Feb, 11:41 AM Test Summary: 61 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20272

  18. Andreas Kienast voted on patch set 6 V +1 CR +1 02/28/18, 10:42

  19. TYPO3com voted on patch set 6 V -1 02/28/18, 10:45 Completed build in 07m 48s on Wed, 28 Feb, 11:45 AM Test Summary: 12 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20273

  20. Frank Nägler uploaded patch set 7 02/28/18, 10:48

  21. Andreas Kienast voted on patch set 7 V +1 CR +1 02/28/18, 10:53

  22. TYPO3com voted on patch set 7 V -1 02/28/18, 10:56 Completed build in 08m 12s on Wed, 28 Feb, 11:56 AM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20274

  23. TYPO3com voted on patch set 7 V +1 02/28/18, 11:02 Completed build in 22m 35s on Wed, 28 Feb, 12:02 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20274

  24. Christian Kuhn voted on patch set 7 V +2 CR +2 02/28/18, 11:03

  25. Christian Kuhn merged patch set 8 02/28/18, 11:03