55922[BUGFIX] Avoid PHP warnings within DatePickerViewHelper
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Wolfgang Klinger +1
- Anja Leichsenring +1
- Frans Saris +1
- Andreas Kienast +1
- Jörg Bösche +1
-
Verified V +2
- Christian Kuhn +2
- Anja Leichsenring +1
- Frans Saris +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 3440
Show 1215 earlier messages
-
Ralf Zimmermann uploaded patch set 1 02/27/18, 13:48
-
Mathias Brodala commented on patch set 2 02/27/18, 13:53
Published edit on patch set 1. -
Anja Leichsenring voted on patch set 2 V +1 CR +1 02/27/18, 13:55
-
Oliver Hader voted on patch set 2 CR +1 02/27/18, 13:55
-
Frans Saris commented on patch set 1 02/27/18, 13:56
DatePickerViewHelper.php:87as already commented in https://review.typo3.org/#/c/55835/ I'm not sure if this is correct. Shouldn't additionalAttributes.placeholder be leading here? -
Oliver Hader commented on patch set 2 CR -1 02/27/18, 13:57
-
TYPO3com voted on patch set 1 V +1 02/27/18, 13:57 Completed build in 09m 01s on Tue, 27 Feb, 02:57 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20216
-
Oliver Hader commented on patch set 2 02/27/18, 13:58
Reply
If applied, this commit will "<subject> -
TYPO3com voted on patch set 2 V +1 02/27/18, 14:01 Completed build in 08m 04s on Tue, 27 Feb, 03:01 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20217
-
Mathias Brodala commented on patch set 1 02/27/18, 14:03
Reply
Sure, sounds good: "If applied, this commit will avoid PHP warnings ...". -
Ralf Zimmermann updated the commit message in patch set 3 02/27/18, 14:09
-
Ralf Zimmermann uploaded patch set 4 02/27/18, 14:11
-
Frank Nägler commented on patch set 4 02/27/18, 14:16
DatePickerViewHelper.php:84I would use: $placeholder = $this->arguments['additionalAttributes']['placeholder'] ?? $this->arguments['placeholder'] ?? ''; to avoid the next problem if the second is also not set. -
TYPO3com voted on patch set 3 V +1 02/27/18, 14:19 Completed build in 09m 15s on Tue, 27 Feb, 03:19 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20218
-
Ralf Zimmermann commented on patch set 4 02/27/18, 14:19
DatePickerViewHelper.php:84Reply$this->arguments['placeholder'] is null, if not set through the viewHelper. It is already available because of $this->registerTagAttribute(...)
-
TYPO3com voted on patch set 4 V +1 02/27/18, 14:21 Completed build in 09m 41s on Tue, 27 Feb, 03:21 PM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20219
-
Mathias Brodala voted on patch set 4 CR +1 02/27/18, 14:22
-
Frank Nägler commented on patch set 4 CR +1 02/27/18, 14:25
DatePickerViewHelper.php:84Replyah ok, thx, make sense -
Mathias Brodala commented on patch set 4 02/27/18, 14:41
This does not make sense as commit title. The former version was perfectly fine. -
Anja Leichsenring commented on patch set 4 02/27/18, 14:42
Should really the additionalAttributes['placeholder'] take precedence over arguments['placeholder']? I was under the impression it should be the other way around, just without the warning and, I miss some documentation example. How is it meant to be in a yaml config, where can one put placeholders, and how are they processed? -
Ralf Zimmermann commented on patch set 4 02/27/18, 14:51
> Patch Set 4: > > Should really the additionalAttributes['placeholder'] take precedence over arguments['placeholder']? I was under the impression it should be the other way around, just without the warning The placeholder attribute from the DatePickerViewHelper is not used within the default DatePicker template. If someone uses his own template, he can use the placeholder attribute as a fallback in the case that properties.additionalAttributes.placeholder is not set within the form definition. -
Ralf Zimmermann commented on patch set 4 02/27/18, 15:02
> Patch Set 4: > > > Patch Set 4: > > > > Should really the additionalAttributes['placeholder'] take precedence over arguments['placeholder']? I was under the impression it should be the other way around, just without the warning > > The placeholder attribute from the DatePickerViewHelper is not used > within the default DatePicker template. > If someone uses his own template, he can use the placeholder attribute > as a fallback in the case that > properties.additionalAttributes.placeholder is not set within the form definition. The DatePickerViewHelper now checks if properties.additionalAttributes.placeholder is set. If not, it checks if the placeholder attribute is filled. If none of the attributes exist, then it uses the dateFormat argument as the default palceholder. additionalAttributes docs are here: https://docs.typo3.org/typo3cms/extensions/form/Config/proto/formElements/Index.html#properties-fluidadditionalattributes "The values within this array goes directely into the fluid form element viewhelpers property additionalAttributes." -
Anja Leichsenring commented on patch set 4 V +1 CR +1 02/27/18, 15:05
thank you Ralf. So let's get this baby in. -
Frans Saris commented on patch set 4 V +1 CR -1 02/27/18, 15:33
The commit message title needs to be adjusted. Would also say: "Avoid PHP warnings within ext:form DatePickerViewHelper" -
Ralf Zimmermann updated the commit message in patch set 5 02/27/18, 15:36
-
Mathias Brodala voted on patch set 5 CR +1 02/27/18, 15:39
-
Georg Ringer commented on patch set 5 CR -1 02/27/18, 15:39
remove "EXT:form" from commit msg title -
TYPO3com voted on patch set 5 V +1 02/27/18, 15:46 Completed build in 10m 14s on Tue, 27 Feb, 04:46 PM Test Summary: 30884 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20229
-
Ralf Zimmermann updated the commit message in patch set 6 02/27/18, 15:47
-
TYPO3com voted on patch set 6 V +1 02/27/18, 16:01 Completed build in 14m 14s on Tue, 27 Feb, 05:01 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20231
-
Frans Saris voted on patch set 6 V +1 CR +1 02/27/18, 16:40
-
Wolfgang Klinger voted on patch set 6 CR +1 02/27/18, 16:58
-
Andreas Kienast voted on patch set 6 CR +1 02/27/18, 19:11
-
Frans Saris commented on patch set 6 02/27/18, 19:18
To verify this patch; create a form with a date field and leave the placeholder empty. Without the patch the FE will throw a exception. -
Ralf Zimmermann commented on patch set 6 02/27/18, 19:23
> Patch Set 6: > > To verify this patch; create a form with a date field and leave the placeholder empty. Without the patch the FE will throw a exception. And installtool setting SYS/exceptionalErrors must be >= 12290 -
Anja Leichsenring voted on patch set 6 V +1 CR +1 02/28/18, 08:23
-
Jörg Bösche voted on patch set 6 CR +1 02/28/18, 08:38
-
Christian Kuhn voted on patch set 6 V +2 CR +2 02/28/18, 09:53
-
Christian Kuhn merged patch set 7 02/28/18, 09:53
-
Christian Kuhn commented on patch set 7 02/28/18, 09:54
Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 5fb31609a35036c8306f3dbea65a3900aacbcd03