55926[BUGFIX] Ensured all FAL drivers are loaded in installtool clear processed files
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1719
-
Frans Saris uploaded patch set 1 02/27/18, 15:52
-
TYPO3com voted on patch set 1 V +1 02/27/18, 16:07 Completed build in 14m 27s on Tue, 27 Feb, 05:07 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1958
-
Sascha Egerer commented on patch set 1 CR -1 03/08/18, 10:45
"clean" in commit message should be "clear". And how about adjusting the commit message to "Ensure all FAL drivers are loaded in cleanProcessedFiles installtool step" (feel free to shorten it a bit ;) )CleanUp.php:295The comment says "files of local storages are deleted". So do we need custom drivers here? And if so this comment should be adjusted. -
Frans Saris commented on patch set 1 04/15/18, 09:29
CleanUp.php:295Reply Unresolvedwill adjust the comment. no custom stuff needed for this -
Frans Saris commented on patch set 2 04/15/18, 09:31
Published edit on patch set 1. -
TYPO3com voted on patch set 2 V +1 04/15/18, 09:40 Completed build in 09m 21s on Sun, 15 Apr, 11:40 AM Test Summary: 58267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2273
-
Wouter Wolters voted on patch set 2 CR +1 04/16/18, 18:20
-
Mona Muzaffar voted on patch set 2 CR +1 06/01/18, 15:20
-
Patrick Schriner voted on patch set 2 CR +1 06/22/18, 22:10
-
Jörg Bösche voted on patch set 2 CR +1 06/27/18, 06:43
-
Frank Nägler commented on patch set 2 11/02/18, 12:25
Is this only an issuer in v8? no issue in v9 / master? -
Ioulia Kondratovitch voted on patch set 2 V +1 CR +1 12/05/18, 17:01
-
Susi Moog commented on patch set 2 CR -1 03/06/19, 12:10
Imho this change needs to go to master first - compare \TYPO3\CMS\Install\Controller\MaintenanceController::clearTypo3tempFilesAction in master -
Frans Saris commented on patch set 2 03/06/19, 19:01
If I remember correctly this part isn't present anymore in master. It was completely rewritten there -
Susi Moog commented on patch set 2 03/06/19, 20:47
> Patch Set 2: > > If I remember correctly this part isn't present anymore in master. It was completely rewritten there no it isn't, that's the line I posted above. It was split in two methods but the code is the same (and extTables/localconf are not loaded in master either). -
Susi Moog commented on patch set 2 03/06/19, 20:48
should have been "it wasn't" in my last comment. writing is hard. anyway, what I wanted to say: yes, this is also a problem on master. -
Wouter Wolters wrote 06/04/19, 13:16
Removed reviewer Wouter Wolters with the following votes: * Code-Review+1 by Wouter Wolters <typo3@wouterwolters.nl> -
Anja Leichsenring wrote 09/09/19, 08:38
Removed reviewer Anja Leichsenring. -
Susi Moog abandoned the change 10/26/19, 07:42
It's already fixed in master, as 8.7 is in critical fix mode, I will abandon this patch.