55928[BUGFIX] Set content object for ConfigurationManager of FLUIDTEMPLATE
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 911
-
Manuel Selbach uploaded patch set 1 02/27/18, 17:32
-
TYPO3com voted on patch set 1 V -1 02/27/18, 17:42 Completed build in 09m 13s on Tue, 27 Feb, 06:42 PM Test Summary: 2 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20234
-
Manuel Selbach uploaded patch set 2 02/27/18, 19:37
-
TYPO3com voted on patch set 2 V +1 02/27/18, 19:46 Completed build in 09m 31s on Tue, 27 Feb, 08:46 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20240
-
Benjamin Franzke commented on patch set 2 02/27/18, 21:27
Using extbase ConfigurationManagerInterface::getConfiguration() in a DataProcessor is bad practice IMO (although I agree that it's a pity that the bugfix broke those usages). The DataProcessors do not run through extbase Bootstrap so there's no global extbase state that they can rely on. This patch adds another (kinda ugly workaround) on top of the previous workaround which fixed a (still open) bug in fluid. I would actually prefer to revert the previous BUGFIX, IF we get https://github.com/TYPO3/Fluid/pull/342 merged (and released as bugfix). That pull request fixes the actual fluid bug, that made the previous BUGFIX necessary.FluidTemplateContentObject.php:92That's more functional change here. If I see things right, the StandaloneView constructor _always_ sets a new ContentObjectRenderer (not only if FLUIDTEMPLATE is a parent, as this line does).FluidTemplateContentObject.php:122UnresolvedStandaloneview creates a clean ContentObjectRenderer – not sure we should inject the FLUIDTEMPLATE cObj in a BUGIX (functional change) -
Benjamin Franzke commented on patch set 2 CR -1 03/05/18, 17:02
I asked Claus Due whether https://github.com/TYPO3/Fluid/pull/342 will be included in the next fluid bugfix release. He said that he plans to do that. Therefore we should wait for that release and revert the other patch then. -
Claus Due commented on patch set 2 CR -1 03/06/18, 13:20
Should work, just the nit-picking to make it perfectFluidTemplateContentObject.php:92Reply UnresolvedIf you move this a bit further down you don't need the condition checking if $this->view === nullFluidTemplateContentObject.php:121You may want to load ConfigurationManagerInterface instead of the implementation -
Claus Due commented on patch set 2 03/06/18, 13:26
This should be fitted with a unit test: the tests currently work because of the condition (see comment in code) - so the addition isn't tested at all. Removing the condition and adding the test would make this perfect. -
Benjamin Franzke commented on patch set 2 03/07/18, 12:20
The fluid bug has been fixed in 2.5.2. I've therefore created https://review.typo3.org/c/56035/ as an alternative fix. Manuel, please test (it's imported to test that one together with fluid 2.5.2). -
Manuel Selbach commented on patch set 2 03/07/18, 21:58
Please find my test result in https://review.typo3.org/#/c/56035/ -
Christian Kuhn abandoned the change 03/07/18, 22:17