Review main Merged

55930[BUGFIX] Add upgrade wizard to keep sorting of sys_language records

Georg Ringer CR +2 V +2 Normal +107 −0 updated 03/12/18, 22:47

Commit message

To keep the sorting after an upgrade from 7.6 to 8.7 and later, an
upgrade wizard is added.

Review

  • Code review CR +2
    • Benni Mack +2
    • Daniel Goerz +1
    • Tobi Kretschmann +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1823

  1. Georg Ringer uploaded patch set 1 02/27/18, 20:42

  2. TYPO3com voted on patch set 1 V +1 02/27/18, 20:51 Completed build in 08m 49s on Tue, 27 Feb, 09:51 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20246

  3. Wolfgang Klinger voted on patch set 1 CR +1 02/28/18, 07:00

  4. Jörg Bösche uploaded patch set 2 02/28/18, 08:57

  5. TYPO3com voted on patch set 2 V +1 02/28/18, 09:05 Completed build in 08m 25s on Wed, 28 Feb, 10:05 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20262

  6. Jörg Bösche uploaded patch set 3 03/06/18, 13:05

  7. Sascha Rademacher voted on patch set 3 CR +1 03/06/18, 13:10

  8. Tobi Kretschmann commented on patch set 2 03/06/18, 13:14

    LanguageSortingUpdate.php:58

    if ($hasAffectedRows === true) {
  9. Jörg Bösche uploaded patch set 4 03/06/18, 13:14

  10. TYPO3com voted on patch set 3 V +1 03/06/18, 13:14 Completed build in 08m 40s on Tue, 6 Mar, 02:14 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20575

  11. Jörg Bösche commented on patch set 2 03/06/18, 13:15

    LanguageSortingUpdate.php:58 Reply

    Done
  12. Tobi Kretschmann voted on patch set 4 CR +1 03/06/18, 13:17

  13. TYPO3com voted on patch set 4 V +1 03/06/18, 13:23 Completed build in 08m 29s on Tue, 6 Mar, 02:23 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20576

  14. Christian Kuhn commented on patch set 4 CR -1 03/08/18, 01:17

    LanguageSortingUpdate.php:52

    named params.

    LanguageSortingUpdate.php:81

    named params

    LanguageSortingUpdate.php:82

    that one is bogus since 'sorting' is defined as not null: sorting int(11) unsigned DEFAULT '0' NOT NULL,
  15. Christian Kuhn commented on patch set 4 03/08/18, 01:19

    LanguageSortingUpdate.php:84

    i guess you should add an explicit order by title here to not rely on implicit db engine magic here, if you want to stick to the class comment and not (most dbmbs) order implicitely by uid.
  16. Georg Ringer uploaded patch set 5 03/08/18, 19:43

  17. TYPO3com voted on patch set 5 V +1 03/08/18, 19:54 Completed build in 10m 39s on Thu, 8 Mar, 08:54 PM Test Summary: 30837 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20708

  18. Christian Kuhn voted on patch set 5 V +1 CR +1 03/09/18, 00:56

  19. Tobi Kretschmann voted on patch set 5 CR +1 03/09/18, 06:37

  20. Jörg Bösche voted on patch set 5 CR +1 03/09/18, 07:17

  21. Benni Mack voted on patch set 5 V +2 CR +2 03/09/18, 15:19

  22. Daniel Goerz voted on patch set 5 CR +1 03/12/18, 09:55

  23. Christian Kuhn merged patch set 6 03/12/18, 22:47