55933[BUGFIX] Make sure that mass actions actually process all changes
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Tobi Kretschmann +1
- Stephan Großberndt +1
- Frank Nägler +1
- Andreas Kienast +1
-
Verified V +2
- Christian Kuhn +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1419
-
Benedikt Huss uploaded patch set 1 02/28/18, 08:38
-
TYPO3com voted on patch set 1 V +1 02/28/18, 08:46 Completed build in 07m 51s on Wed, 28 Feb, 09:46 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20261
-
Stephan Großberndt commented on patch set 1 02/28/18, 09:08
Backend.js:1057Just to be sure - result.processed contains the total number of processed items, not just the number of items processed in the last request?Backend.js:1079just by looking at the code - wouldn't ).done(sendRequestReponseHandler); be enough instead of ).done(function(response) { var payload = response[0].result; sendRequest( massAction, payload ).done(sendRequestReponseHandler); }); -
Benedikt Huss uploaded patch set 2 02/28/18, 09:11
-
TYPO3com voted on patch set 2 V +1 02/28/18, 09:19 Completed build in 07m 45s on Wed, 28 Feb, 10:19 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20264
-
Stephan Großberndt commented on patch set 3 02/28/18, 09:25
Published edit on patch set 2. -
Stephan Großberndt commented on patch set 4 02/28/18, 09:26
Published edit on patch set 3. -
Stephan Großberndt commented on patch set 5 02/28/18, 09:27
Published edit on patch set 4. -
Stephan Großberndt commented on patch set 5 02/28/18, 09:31
Backend.js:1055Could you please test this again, Benedikt? I was wondering if this recursion of ".done(sendRequestsUntilAllProcessed) in var sendRequestsUntilAllProcessed" actually works cross-browser https://stackoverflow.com/questions/7065120/calling-a-javascript-function-recursively -
Andreas Kienast voted on patch set 5 CR +1 02/28/18, 09:32
-
TYPO3com voted on patch set 3 V +1 02/28/18, 09:34 Completed build in 09m 02s on Wed, 28 Feb, 10:34 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20265
-
Stephan Großberndt voted on patch set 5 CR +1 02/28/18, 09:34
-
TYPO3com voted on patch set 4 V +1 02/28/18, 09:37 Completed build in 10m 41s on Wed, 28 Feb, 10:37 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20266
-
TYPO3com voted on patch set 5 V +1 02/28/18, 09:39 Completed build in 11m 45s on Wed, 28 Feb, 10:39 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20267
-
Tobi Kretschmann voted on patch set 5 CR +1 02/28/18, 09:54
-
Benedikt Huss commented on patch set 5 02/28/18, 10:09
Backend.js:1055ReplyWorking pretty fine here!Backend.js:1079ReplyYou're right - fixed! -
Frank Nägler voted on patch set 5 V +1 CR +1 02/28/18, 11:37
-
Christian Kuhn voted on patch set 5 V +2 CR +2 02/28/18, 11:37
-
Christian Kuhn merged patch set 6 02/28/18, 11:37
Backend.js:1049