Review main Merged

55937[TASK] Improve strictness of resource access blocking in _.htaccess

Markus Klein CR +2 V +2 Easy +14 −13 updated 02/28/18, 15:26

Commit message

For Apache HTTP versions 2.3+ there is a better way to avoid conflicts
in priority of sections. Since the `if` condition has been introduced
it is ranked the highest priority, hence it is most suitable for
rules to protect sensitive data.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • Nicole Hummel +1
  • Verified V +2
    • Christian Kuhn +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Markus Klein uploaded patch set 1 02/28/18, 12:53

  2. Nicole Hummel commented on patch set 1 02/28/18, 12:58

    _.htaccess:322

    your commit message says this is possible with apache 2.4+ - this comment says is for 2.3+
  3. TYPO3com voted on patch set 1 V +1 02/28/18, 13:04 Completed build in 10m 52s on Wed, 28 Feb, 02:04 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20289

  4. Markus Klein updated the commit message in patch set 2 02/28/18, 13:15

  5. TYPO3com voted on patch set 2 V +1 02/28/18, 13:23 Completed build in 08m 20s on Wed, 28 Feb, 02:23 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20291

  6. Frank Nägler voted on patch set 2 V +1 CR +1 02/28/18, 14:05

  7. Nicole Hummel voted on patch set 2 CR +1 02/28/18, 14:10

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 02/28/18, 15:26

  9. Christian Kuhn merged patch set 3 02/28/18, 15:26

  10. Christian Kuhn commented on patch set 3 02/28/18, 15:26

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 7f02548454352ab654e8c1564d4677259e703e04