55941[TASK] Declare indexes for frequently dispatched queries
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1318
-
Claus Due uploaded patch set 1 02/28/18, 15:11
-
TYPO3com voted on patch set 1 V -1 02/28/18, 15:19 Completed build in 08m 24s on Wed, 28 Feb, 04:19 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20298
-
Markus Klein commented on patch set 1 02/28/18, 15:20
are the test failures really related? if so those tests needs some love, because adding an index must make tests fail... -
TYPO3com commented on patch set 1 02/28/18, 15:28 Completed build in 25m 52s on Wed, 28 Feb, 04:28 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20298
-
Claus Due commented on patch set 1 02/28/18, 15:31
> are the test failures really related? Pretty sure they're not, but I seem to lack the privileges to re-run those tests. -
TYPO3com commented on patch set 1 02/28/18, 15:44 Completed build in 59m 04s on Wed, 28 Feb, 04:44 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20298
-
Markus Klein commented on patch set 1 02/28/18, 15:48
postgres fails -
Mathias Schreiber commented on patch set 2 02/28/18, 16:29
Published edit on patch set 1. -
Mathias Schreiber commented on patch set 2 02/28/18, 16:29
testing something -
Mathias Schreiber commented on patch set 3 02/28/18, 16:40
Published edit on patch set 2. -
TYPO3com voted on patch set 2 V -1 02/28/18, 16:42 Completed build in 13m 20s on Wed, 28 Feb, 05:42 PM Test Summary: 7 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20308
-
TYPO3com voted on patch set 3 V +1 02/28/18, 16:50 Completed build in 10m 09s on Wed, 28 Feb, 05:50 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20310
-
Tymoteusz Motylewski commented on patch set 3 03/01/18, 16:11
@Matthias, are you still testing, or is the latest patch a version ready for review? -
Christian Kuhn commented on patch set 3 03/01/18, 17:27
this is not up to date anymore. -
Christian Kuhn commented on patch set 3 03/01/18, 17:31
ext_tables.sql:289which query is actually fired? *if* that query contains both 'pid' and 'sorting', too. it would be even better to just change the 'parent' index to also contain 'colPos' at the end: KEY parent (pid, sorting, colPos). but that only works if the query in question does contain pid and also sorting. -
Roberto Torresani voted on patch set 3 CR +1 05/11/18, 15:10
-
Mathias Schreiber commented on patch set 3 05/12/18, 10:36
ext_tables.sql:289ReplyI can't think of a query that does not use at least pid and/or sorting (unless it's some custom TS select.uidInList thing that explicitly unsets pidInList - which we shouldn't optimize for in the first place) -
Benni Mack abandoned the change 10/27/18, 16:22
no comments in the last 6 months, no feedback on the questions... will abandon this patch for now