Review TYPO3_8-7 Merged

55946[BUGFIX] Allow browser notifications only on encrypted connection

Christian Kuhn CR +2 V +2 Easy +38 −2 updated 02/28/18, 16:48

Commit message

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Frank Nägler +1
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 02/28/18, 16:37

  2. Frank Nägler voted on patch set 1 CR +1 02/28/18, 16:38

  3. TYPO3com voted on patch set 1 V +1 02/28/18, 16:47 Completed build in 09m 20s on Wed, 28 Feb, 05:47 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1969

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/28/18, 16:48

  5. Christian Kuhn merged patch set 2 02/28/18, 16:48