Review main Merged

55948[BUGFIX] Add space in lockedRecords messages for translated languages

Josef Glatz CR +2 V +2 Easy +7 −7 updated 02/28/18, 20:35

Commit message

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Review

  • Code review CR +2
    • Markus Klein +2
    • Andreas Kienast +1
  • Verified V +2
    • Markus Klein +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1214

  1. Josef Glatz uploaded patch set 1 02/28/18, 19:09

  2. Josef Glatz commented on patch set 1 02/28/18, 19:12

    Would be nice if you can vote/review this patch @lolli: I added u because of the fact you wrote the initial code part
  3. TYPO3com voted on patch set 1 V +1 02/28/18, 19:17 Completed build in 08m 32s on Wed, 28 Feb, 08:17 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20317

  4. Michael Oehlhof voted on patch set 1 CR +1 02/28/18, 19:18

  5. Markus Klein commented on patch set 1 02/28/18, 19:20

    BackendUtility.php:1159

    we can remove the spaces here then too, right?
  6. Josef Glatz uploaded patch set 2 02/28/18, 19:21

  7. Josef Glatz commented on patch set 2 02/28/18, 19:23

    > Patch Set 1: > > (1 comment) yep. see patch set 2
  8. Josef Glatz commented on patch set 2 02/28/18, 19:23

    BackendUtility.php:1161 Unresolved

    this is just for the existing localized strings which are imported from the translation server
  9. TYPO3com voted on patch set 2 V +1 02/28/18, 19:31 Completed build in 09m 19s on Wed, 28 Feb, 08:31 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20319

  10. Andreas Kienast voted on patch set 2 CR +1 02/28/18, 19:40

  11. Andreas Kienast voted on patch set 2 V +1 02/28/18, 19:46

  12. Markus Klein voted on patch set 2 V +2 CR +2 02/28/18, 20:35

  13. Markus Klein merged patch set 3 02/28/18, 20:35

  14. Markus Klein commented on patch set 3 02/28/18, 20:35

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit ff1fc9b95f6f5b000449184c0ca025c115073d92