Review TYPO3_8-7 Merged

55951[BUGFIX] Add space in lockedRecords messages for translated languages

Markus Klein CR +2 V +2 Easy +7 −7 updated 02/28/18, 20:55

Commit message

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Markus Klein commented on patch set 1 02/28/18, 20:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/28/18, 20:48 Completed build in 12m 30s on Wed, 28 Feb, 09:48 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1972

  3. Markus Klein voted on patch set 1 V +2 CR +2 02/28/18, 20:55

  4. Markus Klein merged patch set 2 02/28/18, 20:55