55952[TASK] Remove unnecessary parentheses
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Mathias Schreiber +1
-
Verified V +2
- Frank Nägler +2
- Mathias Schreiber +1
- TYPO3com +1 CI
Issues 1
Files 113
- typo3/sysext/backend/Classes/Backend/ToolbarItems/ShortcutToolbarItem.php1+2 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementHistoryController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php+1 −1
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+1 −1
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/Module/BackendModuleRepository.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php+4 −4
- typo3/sysext/backend/Classes/Form/FieldWizard/SelectIcons.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php+1 −1
- typo3/sysext/backend/Classes/Form/AbstractNode.php+3 −3
- typo3/sysext/backend/Classes/Form/FormResultCompiler.php+2 −2
- typo3/sysext/backend/Classes/Module/ModuleLoader.php+1 −1
- typo3/sysext/backend/Classes/Provider/PageTsBackendLayoutDataProvider.php1+2 −2
- typo3/sysext/backend/Classes/RecordList/AbstractRecordList.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+5 −5
- typo3/sysext/backend/Classes/View/PageLayoutView.php+12 −5
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+5 −2
- typo3/sysext/core/Classes/Cache/Backend/FileBackend.php+22 −4
- typo3/sysext/core/Classes/Cache/Backend/RedisBackend.php+1 −1
Show 93 more files
- typo3/sysext/core/Classes/Charset/CharsetConverter.php+3 −3
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+1 −1
- typo3/sysext/core/Classes/Core/Bootstrap.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php4+7 −4
- typo3/sysext/core/Classes/Database/QueryView.php+3 −3
- typo3/sysext/core/Classes/Database/ReferenceIndex.php+1 −1
- typo3/sysext/core/Classes/Database/RelationHandler.php+1 −1
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php+3 −3
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+3 −3
- typo3/sysext/core/Classes/Error/ErrorHandler.php+1 −1
- typo3/sysext/core/Classes/Html/HtmlParser.php+2 −2
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Classes/Http/MiddlewareStackResolver.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+5 −5
- typo3/sysext/core/Classes/Imaging/IconRegistry.php+1 −1
- typo3/sysext/core/Classes/Integrity/DatabaseIntegrityCheck.php+2 −2
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+1 −1
- typo3/sysext/core/Classes/Mail/Rfc822AddressesParser.php+2 −2
- typo3/sysext/core/Classes/Package/PackageManager.php+1 −1
- typo3/sysext/core/Classes/Page/PageRenderer.php+8 −8
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+5 −5
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+2 −2
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+4 −4
- typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+12 −9
- typo3/sysext/core/Classes/Utility/MathUtility.php+2 −2
- typo3/sysext/core/Tests/Unit/Cache/Backend/FileBackendTest.php+7 −1
- typo3/sysext/core/Tests/Unit/Cache/Backend/RedisBackendTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Package/PackageManagerTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+1 −1
- typo3/sysext/documentation/Classes/Domain/Repository/TableManualRepository.php+1 −1
- typo3/sysext/documentation/Classes/Utility/MiscUtility.php+1 −1
- typo3/sysext/extbase/Classes/Mvc/Controller/CommandController.php+1 −1
- typo3/sysext/extbase/Classes/Utility/DebuggerUtility.php+2 −2
- typo3/sysext/extbase/Tests/Functional/Persistence/CountTest.php+3 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php+1 −1
- typo3/sysext/extbase/Tests/Unit/SignalSlot/DispatcherTest.php+2 −2
- typo3/sysext/extensionmanager/Tests/Unit/Domain/Repository/RepositoryRepositoryTest.php+2 −2
- typo3/sysext/feedit/Classes/FrontendEditPanel.php+1 −1
- typo3/sysext/filelist/Classes/FileList.php+12 −4
- typo3/sysext/fluid/Classes/ViewHelpers/CObjectViewHelper.php+1 −1
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/form/Classes/Domain/Finishers/ConfirmationFinisher.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+1 −1
- typo3/sysext/form/Classes/Service/TranslationService.php9+5 −5
- typo3/sysext/frontend/Classes/AdminPanel/PreviewModule.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+7 −7
- typo3/sysext/frontend/Classes/Controller/ShowImageController.php+1 −1
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php+2 −2
- typo3/sysext/frontend/Classes/Middleware/FrontendUserAuthenticator.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageGenerator.php+1 −1
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −1
- typo3/sysext/impexp/Classes/Import.php+3 −3
- typo3/sysext/impexp/Classes/ImportExport.php+5 −5
- typo3/sysext/indexed_search/Classes/Controller/AdministrationController.php+2 −2
- typo3/sysext/indexed_search/Classes/Controller/SearchController.php+10 −4
- typo3/sysext/indexed_search/Classes/Domain/Repository/IndexSearchRepository.php+2 −2
- typo3/sysext/indexed_search/Classes/Utility/DoubleMetaPhoneUtility.php+39 −9
- typo3/sysext/indexed_search/Classes/ViewHelpers/PageBrowsingViewHelper.php+1 −1
- typo3/sysext/indexed_search/Classes/FileContentParser.php+6 −6
- typo3/sysext/indexed_search/Classes/Lexer.php+5 −1
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+2 −2
- typo3/sysext/install/Classes/FolderStructure/DefaultPermissionsCheck.php+10 −10
- typo3/sysext/install/Classes/Report/InstallStatusReport.php+9 −3
- typo3/sysext/install/Classes/Updates/BackendLayoutIconUpdateWizard.php+2 −2
- typo3/sysext/install/Classes/Updates/FrontendUserImageUpdateWizard.php+2 −2
- typo3/sysext/install/Classes/Updates/SeparateSysHistoryFromSysLogUpdate.php+1 −1
- typo3/sysext/install/Tests/Unit/Service/CoreVersionServiceTest.php+4 −4
- typo3/sysext/linkvalidator/Classes/Task/ValidatorTask.php+1 −1
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+2 −2
- typo3/sysext/lowlevel/Classes/Command/RteImagesCommand.php+1 −1
- typo3/sysext/lowlevel/Classes/Controller/DatabaseIntegrityController.php+1 −1
- typo3/sysext/lowlevel/Classes/Utility/ArrayBrowser.php+3 −3
- typo3/sysext/recordlist/Classes/RecordList/AbstractDatabaseRecordList.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+33 −11
- typo3/sysext/reports/Classes/Status.php+1 −1
- typo3/sysext/rsaauth/Classes/Storage/SplitStorage.php+1 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+1 −1
- typo3/sysext/sys_action/Classes/ActionTask.php+1 −1
- typo3/sysext/t3editor/Classes/T3editor.php+2 −2
- typo3/sysext/taskcenter/Classes/Controller/TaskModuleController.php+1 −1
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+2 −2
- typo3/sysext/viewpage/Classes/Controller/ViewModuleController.php+4 −4
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+50 −8
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+8 −1
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+2 −2
- typo3/sysext/workspaces/Classes/Service/StagesService.php2+4 −4
Review log 1824
-
Wouter Wolters uploaded patch set 1 02/28/18, 20:36
-
TYPO3com voted on patch set 1 V -1 02/28/18, 20:37 Completed build in 01m 06s on Wed, 28 Feb, 09:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20323
-
Wouter Wolters uploaded patch set 2 02/28/18, 20:40
-
TYPO3com voted on patch set 2 V +1 02/28/18, 20:55 Completed build in 14m 52s on Wed, 28 Feb, 09:55 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20327
-
Benni Mack commented on patch set 2 02/28/18, 21:36
PageTsBackendLayoutDataProvider.php:173can be shortened ?:QueryGenerator.php:1643let's fix this "0"TranslationService.php:363we can switch that and use ?:TranslationService.php:376sameTranslationService.php:388sameTranslationService.php:450same -
Anja Leichsenring commented on patch set 2 03/01/18, 20:52
I do a rebase now. -
Anja Leichsenring uploaded patch set 3 03/01/18, 21:09
-
Anja Leichsenring commented on patch set 3 03/01/18, 21:09
QueryGenerator.php:1643Replycan't decipher the meaning, please explain? -
Benni Mack commented on patch set 3 03/01/18, 21:11
QueryGenerator.php:952well, $begin = 0 is "0"... just write 0 -
Anja Leichsenring uploaded patch set 4 03/01/18, 21:16
-
Anja Leichsenring commented on patch set 4 V +1 CR +1 03/01/18, 21:17
QueryGenerator.php:952Replygot it :) Sorry for being slow -
TYPO3com voted on patch set 3 V -1 03/01/18, 21:20 Completed build in 10m 28s on Thu, 1 Mar, 10:20 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20397
-
TYPO3com voted on patch set 4 V -1 03/01/18, 21:27 Completed build in 10m 09s on Thu, 1 Mar, 10:27 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20400
-
Wouter Wolters commented on patch set 4 03/01/18, 22:36
TranslationService.php:363this wrong if I'm correct, ?? does not catch an empty string.TranslationService.php:376Unresolvedwrong tooTranslationService.php:388Unresolvedwrong tooTranslationService.php:450Unresolvedwrong too -
Frank Nägler commented on patch set 4 CR -1 03/02/18, 09:18
TranslationService.php:363Reply Unresolvedcorrect, an empty string will be accepted, so is a behavior change: https://3v4l.org/BmHoc -
Mathias Schreiber uploaded patch set 5 03/02/18, 11:04
-
Mathias Schreiber voted on patch set 5 V +1 CR +1 03/02/18, 11:05
-
TYPO3com voted on patch set 5 V -1 03/02/18, 11:14 Completed build in 09m 09s on Fri, 2 Mar, 12:14 PM Test Summary: 12 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20423
-
TYPO3com voted on patch set 5 V +1 03/02/18, 11:15 Completed build in 19m 50s on Fri, 2 Mar, 12:15 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20423
-
Frank Nägler voted on patch set 5 V +1 CR +1 03/02/18, 11:16
-
Frank Nägler voted on patch set 5 V +2 CR +2 03/02/18, 11:16
-
Frank Nägler merged patch set 6 03/02/18, 11:16
-
Christian Kuhn commented on patch set 6 03/02/18, 15:34
StagesService.php:319this is probably a rebase issue since it reverts that part of the is_null() patch. -
Frank Nägler commented on patch set 6 03/02/18, 15:35
StagesService.php:319Replydamn, you are right, looks incorrect, will take care
ShortcutToolbarItem.php:276