Review main Merged

55952[TASK] Remove unnecessary parentheses

Wouter Wolters CR +2 V +2 Hard +431 −265 updated 03/02/18, 15:35

Commit message

These parentheses are redundant and may be safely removed.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 113

Show 93 more files

Review log 1824

  1. Wouter Wolters uploaded patch set 1 02/28/18, 20:36

  2. TYPO3com voted on patch set 1 V -1 02/28/18, 20:37 Completed build in 01m 06s on Wed, 28 Feb, 09:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20323

  3. Wouter Wolters uploaded patch set 2 02/28/18, 20:40

  4. TYPO3com voted on patch set 2 V +1 02/28/18, 20:55 Completed build in 14m 52s on Wed, 28 Feb, 09:55 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20327

  5. Benni Mack commented on patch set 2 02/28/18, 21:36

    ShortcutToolbarItem.php:276

    can we fix this directly please? using Permission::SHOW

    PageTsBackendLayoutDataProvider.php:173

    can be shortened ?:

    QueryGenerator.php:1643

    let's fix this "0"

    TranslationService.php:363

    we can switch that and use ?:

    TranslationService.php:376

    same

    TranslationService.php:388

    same

    TranslationService.php:450

    same
  6. Anja Leichsenring commented on patch set 2 03/01/18, 20:52

    I do a rebase now.
  7. Anja Leichsenring uploaded patch set 3 03/01/18, 21:09

  8. Anja Leichsenring commented on patch set 3 03/01/18, 21:09

    QueryGenerator.php:1643 Reply

    can't decipher the meaning, please explain?
  9. Benni Mack commented on patch set 3 03/01/18, 21:11

    QueryGenerator.php:952

    well, $begin = 0 is "0"... just write 0
  10. Anja Leichsenring uploaded patch set 4 03/01/18, 21:16

  11. Anja Leichsenring commented on patch set 4 V +1 CR +1 03/01/18, 21:17

    QueryGenerator.php:952 Reply

    got it :) Sorry for being slow
  12. TYPO3com voted on patch set 3 V -1 03/01/18, 21:20 Completed build in 10m 28s on Thu, 1 Mar, 10:20 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20397

  13. TYPO3com voted on patch set 4 V -1 03/01/18, 21:27 Completed build in 10m 09s on Thu, 1 Mar, 10:27 PM Test Summary: 3 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20400

  14. Wouter Wolters commented on patch set 4 03/01/18, 22:36

    TranslationService.php:363

    this wrong if I'm correct, ?? does not catch an empty string.

    TranslationService.php:376 Unresolved

    wrong too

    TranslationService.php:388 Unresolved

    wrong too

    TranslationService.php:450 Unresolved

    wrong too
  15. Frank Nägler commented on patch set 4 CR -1 03/02/18, 09:18

    TranslationService.php:363 Reply Unresolved

    correct, an empty string will be accepted, so is a behavior change: https://3v4l.org/BmHoc
  16. Mathias Schreiber uploaded patch set 5 03/02/18, 11:04

  17. Mathias Schreiber voted on patch set 5 V +1 CR +1 03/02/18, 11:05

  18. TYPO3com voted on patch set 5 V -1 03/02/18, 11:14 Completed build in 09m 09s on Fri, 2 Mar, 12:14 PM Test Summary: 12 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20423

  19. TYPO3com voted on patch set 5 V +1 03/02/18, 11:15 Completed build in 19m 50s on Fri, 2 Mar, 12:15 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20423

  20. Frank Nägler voted on patch set 5 V +1 CR +1 03/02/18, 11:16

  21. Frank Nägler voted on patch set 5 V +2 CR +2 03/02/18, 11:16

  22. Frank Nägler merged patch set 6 03/02/18, 11:16

  23. Christian Kuhn commented on patch set 6 03/02/18, 15:34

    StagesService.php:319

    this is probably a rebase issue since it reverts that part of the is_null() patch.
  24. Frank Nägler commented on patch set 6 03/02/18, 15:35

    StagesService.php:319 Reply

    damn, you are right, looks incorrect, will take care