Review main Merged

55961[TASK] Move Page ID resolving to PSR-15 middleware

Benni Mack CR +2 V +2 Normal +87 −24 updated 03/01/18, 15:27

Commit message

The next PSR-15 middleware is introduced that was previously part of the
Frontend Request Handler. It defines the actual (current) implementation
to determine the Page ID and GET/POST parameters handled in TSFE.

A possible alternative could be a Router doing the same process at this
very position currently.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2
    • Frank Nägler +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1617

  1. Benni Mack uploaded patch set 1 03/01/18, 07:29

  2. Benjamin Franzke commented on patch set 1 03/01/18, 08:11

    PageResolver.php:53 Unresolved

    I think the siteScript re-assignment can be dropped savely.

    PageResolver.php:54 Unresolved

    Should be: $this->checkAlternativeIdMethods($GLOBALS['TSFE']);
  3. Benni Mack commented on patch set 2 03/01/18, 08:13

    Published edit on patch set 1.
  4. Benjamin Franzke uploaded patch set 3 03/01/18, 08:19

  5. Benjamin Franzke voted on patch set 3 CR +1 03/01/18, 08:20

  6. Benjamin Franzke uploaded patch set 4 03/01/18, 08:27

  7. Benjamin Franzke voted on patch set 4 V +1 CR +1 03/01/18, 08:28

  8. Wouter Wolters voted on patch set 4 CR +1 03/01/18, 10:17

  9. Benni Mack updated the commit message in patch set 5 03/01/18, 10:52

  10. TYPO3com voted on patch set 5 V +1 03/01/18, 11:02 Completed build in 09m 50s on Thu, 1 Mar, 12:02 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20345

  11. Benjamin Franzke voted on patch set 5 V +1 CR +1 03/01/18, 11:19

  12. Frans Saris commented on patch set 5 03/01/18, 11:57

    RequestHandler.php:94

    Time tracking has been dropped?
  13. Benni Mack commented on patch set 5 03/01/18, 14:49

    RequestHandler.php:94 Reply Unresolved

    oh yes. I can re-add them, but I actually do hope that Susi, working on the AdminPanel refactoring where this kicks in, will rather use a PSR-3 compatible logging mechanism for measuring time. Will check with Susi.
  14. Susi Moog commented on patch set 5 03/01/18, 15:05

    > Patch Set 5: > > (1 comment) will keep it in mind - not directly for the next patch set but as part of the initiative.
  15. Christian Kuhn voted on patch set 5 V +1 CR +1 03/01/18, 15:26

  16. Frank Nägler voted on patch set 5 V +2 CR +2 03/01/18, 15:27

  17. Frank Nägler merged patch set 6 03/01/18, 15:27