Review main Merged

55965[TASK] Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboo

Benjamin Franzke CR +2 V +2 Easy +1 −1 updated 03/05/18, 14:43

Commit message

If typo3/testing-framework needs to be synced with changes
in core it needs to require the dev branch of the upcoming
release as the compatibility to previous releases needs to
be dropped.
Therefore it has to define a dependency in composer.json like:
  "typo3/cms-core": "^9.2@dev"

If composer install is executed with COMPOSER_ROOT_VERSION
set to 9.1.0 that produces a conflict, therefore we raise
the version to 9.2.0@dev. That actually aligns the setting
with the branch alias (9.2.x-dev) set in composer.json.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benjamin Franzke uploaded patch set 1 03/01/18, 10:55

  2. TYPO3com voted on patch set 1 V +1 03/01/18, 11:07 Completed build in 11m 42s on Thu, 1 Mar, 12:07 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20346

  3. Christian Kuhn commented on patch set 1 CR -1 03/01/18, 13:21

    will take care when bamboo is less busy than now.
  4. Christian Kuhn commented on patch set 1 V +2 CR +2 03/05/18, 14:42

    Published the plan updated and tortured bamboo a bit to see if an issue pops up. Looks good to me, lets go for it.
  5. Christian Kuhn merged patch set 2 03/05/18, 14:43