55976[FEATURE] Make position of sys notes configurable
Commit message
Review
-
Code review CR +2
- Benni Mack +2
- Daniel Goerz +1
- Georg Ringer +1
- Guido Schmechel +1
-
Verified V +2
- Benni Mack +2
- Daniel Goerz +1
- Georg Ringer +1
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Documentation/Changelog/master/Feature-83965-MakePositionOfSysNotesConfigurable.rstnew+15 −0
- typo3/sysext/sys_note/Classes/Controller/NoteController.php+3 −2
- typo3/sysext/sys_note/Classes/Domain/Repository/SysNoteRepository.php+13 −5
- typo3/sysext/sys_note/Classes/Hook/PageHook.php+17 −2
- typo3/sysext/sys_note/Classes/Hook/RecordListHook.php2+16 −2
- typo3/sysext/sys_note/Configuration/TCA/sys_note.php+24 −1
- typo3/sysext/sys_note/Resources/Private/Language/locallang_tca.xlf+9 −0
- typo3/sysext/sys_note/ext_localconf.php+5 −3
- typo3/sysext/sys_note/ext_tables.sql+1 −0
Review log 1625
-
Georg Ringer uploaded patch set 1 03/01/18, 18:37
-
TYPO3com voted on patch set 1 V -1 03/01/18, 18:48 Completed build in 11m 24s on Thu, 1 Mar, 07:48 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20387
-
Georg Ringer updated the commit message in patch set 2 03/01/18, 18:54
-
TYPO3com voted on patch set 2 V -1 03/01/18, 19:03 Completed build in 08m 59s on Thu, 1 Mar, 08:03 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20389
-
Georg Ringer uploaded patch set 3 03/01/18, 19:58
-
TYPO3com voted on patch set 3 V +1 03/01/18, 20:07 Completed build in 08m 12s on Thu, 1 Mar, 09:07 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20392
-
Benni Mack commented on patch set 3 03/01/18, 21:09
we could use a runtime cache in the NoteController to avoid having two SQL queries to check for sysnotes on a page. -
Peter Kraume commented on patch set 3 V +1 CR -1 03/02/18, 08:42
RecordListHook.php:27Unresolvedheader -
Georg Ringer uploaded patch set 4 03/02/18, 09:39
-
TYPO3com voted on patch set 4 V -1 03/02/18, 09:48 Completed build in 08m 57s on Fri, 2 Mar, 10:48 AM Test Summary: 11 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20418
-
TYPO3com voted on patch set 4 V +1 03/02/18, 11:13 Completed build in 1h 42m 21s on Fri, 2 Mar, 12:13 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20418
-
Daniel Goerz commented on patch set 4 03/02/18, 11:31
RecordListHook.php:36How about using constants for the position? -
Daniel Goerz voted on patch set 4 V +1 03/02/18, 11:37
-
Daniel Goerz uploaded patch set 5 03/02/18, 11:49
-
Daniel Goerz uploaded patch set 6 03/02/18, 11:51
-
TYPO3com voted on patch set 5 V +1 03/02/18, 12:00 Completed build in 11m 21s on Fri, 2 Mar, 01:00 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20430
-
TYPO3com voted on patch set 6 V -1 03/02/18, 12:03 Completed build in 11m 58s on Fri, 2 Mar, 01:03 PM Test Summary: 11 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20431
-
Daniel Goerz uploaded patch set 7 03/02/18, 12:06
-
Georg Ringer voted on patch set 7 V +1 CR +1 03/02/18, 12:14
-
TYPO3com voted on patch set 7 V -1 03/02/18, 12:16 Completed build in 10m 01s on Fri, 2 Mar, 01:16 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20433
-
Daniel Goerz voted on patch set 7 V +1 CR +1 03/02/18, 12:18
-
TYPO3com voted on patch set 7 V +1 03/02/18, 12:26 Completed build in 29m 36s on Fri, 2 Mar, 01:26 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20433
-
Guido Schmechel voted on patch set 7 V +1 CR +1 03/03/18, 21:36
-
Benni Mack voted on patch set 7 V +2 CR +2 03/03/18, 22:31
-
Benni Mack merged patch set 8 03/03/18, 22:31