55981[FEATURE] Replace TYPO3/CMS/Backend/Tooltip with a pure CSS solution
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 38
- Build/Resources/Public/Sass/scaffold/_scaffold.scss+3 −1
- Build/Resources/Public/Sass/typo3/_element_tooltip.scss4+202 −2
- Build/Resources/Public/Sass/variables/_main.scss+1 −0
- Build/Resources/Public/Sass/_minimal.scss+0 −1
- typo3/sysext/backend/Classes/Controller/ContentElement/MoveElementController.php+0 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+0 −1
- typo3/sysext/backend/Classes/Form/Element/SelectCheckBoxElement.php+0 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+5 −5
- typo3/sysext/backend/Classes/View/PageLayoutView.php+0 −1
- typo3/sysext/backend/Resources/Private/Templates/Page/SortSubPages.html+1 −2
- typo3/sysext/backend/Resources/Private/TypeScript/AjaxDataHandler.ts+5 −7
- typo3/sysext/backend/Resources/Private/TypeScript/ContextHelp.ts+1 −1
- typo3/sysext/backend/Resources/Private/TypeScript/Tooltip.ts3+3 −7
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TreeToolbar.js+3 −5
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js+1 −4
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextHelp.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+3 −13
- typo3/sysext/backend/Resources/Public/JavaScript/Tooltip.js+1 −1
Show 18 more files
- typo3/sysext/beuser/Classes/Controller/PermissionController.php+0 −2
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-82492-ReplaceTYPO3CMSBackendTooltipWithAPureCSSSolution.rstnew+33 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Extensionmanager/InstalledExtensionsCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/CategoryTreeCest.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputDateCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputEvalCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputRangeCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsBasicInputSimpleCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/ElementsGroupCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/FormEngine/Inline1nCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Scheduler/TasksCest.php+7 −7
- typo3/sysext/extensionmanager/Classes/ViewHelpers/ToggleExtensionInstallationStateViewHelper.php+2 −1
- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js+1 −11
- typo3/sysext/recordlist/Resources/Public/JavaScript/Tooltip.js2+7 −10
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+0 −1
- typo3/sysext/scheduler/Resources/Private/Partials/Backend/SchedulerModule/TaskList.html+7 −7
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php2+0 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −12
Review log 2637
Show 712 earlier messages
-
Frank Nägler uploaded patch set 1 03/01/18, 22:47
-
TYPO3com voted on patch set 1 V -1 03/01/18, 22:55 Completed build in 08m 46s on Thu, 1 Mar, 11:55 PM Test Summary: 20 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20410
-
Frank Nägler uploaded patch set 2 03/14/18, 11:02
-
TYPO3com voted on patch set 2 V -1 03/14/18, 11:10 Completed build in 07m 55s on Wed, 14 Mar, 12:10 PM Test Summary: 20 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20918
-
Frank Nägler uploaded patch set 3 08/06/18, 21:24
-
Frank Nägler uploaded patch set 4 08/06/18, 21:26
-
TYPO3com voted on patch set 3 V -1 08/06/18, 21:32 Completed build in 08m 07s on Mon, 6 Aug, 11:32 PM Test Summary: 32 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26235
-
TYPO3com voted on patch set 4 V -1 08/06/18, 21:34 Completed build in 07m 48s on Mon, 6 Aug, 11:34 PM Test Summary: 32 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26236
-
Frank Nägler uploaded patch set 5 08/06/18, 21:57
-
TYPO3com voted on patch set 5 V -1 08/06/18, 22:04 Completed build in 06m 30s on Tue, 7 Aug, 12:04 AM Test Summary: 15 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26237
-
Frank Nägler uploaded patch set 6 08/06/18, 22:12
-
Frank Nägler voted on patch set 5 CR -2 08/06/18, 22:14
-
Frank Nägler voted on patch set 6 CR -2 08/06/18, 22:14
-
TYPO3com voted on patch set 6 V -1 08/06/18, 22:19 Completed build in 07m 12s on Tue, 7 Aug, 12:19 AM Test Summary: 8 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26238
-
Frank Nägler uploaded patch set 7 08/06/18, 22:26
-
TYPO3com voted on patch set 7 V +1 08/06/18, 22:33 Completed build in 06m 35s on Tue, 7 Aug, 12:33 AM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26239
-
Frank Nägler voted on patch set 7 CR 0 08/06/18, 22:33
-
Frank Nägler uploaded patch set 8 08/07/18, 06:59
-
TYPO3com voted on patch set 8 V +1 08/07/18, 07:06 Completed build in 07m 03s on Tue, 7 Aug, 09:06 AM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26240
-
Andreas Kienast commented on patch set 8 CR -1 08/07/18, 20:13
_element_tooltip.scss:59UnresolvedI opt to have max-width instead. Having 160px is a bit large for displaying "id=42" in the record list. But this makes "stretching" to the maximum available width tricky._element_tooltip.scss:67UnresolvedI'd set the line-height to 1.0 and add `font-size: 0.8em`. This change would require some adjustments in the positioning.Tooltip.ts:30Removing any logic here is a breaking change. -
Benni Mack commented on patch set 8 08/08/18, 21:30
BackendUtility.php:1562can we safely remove the <br> logic?Tooltip.js:16comment is outdated, right?TypoScriptTemplateObjectBrowserModuleFunctionController.php:379method is not needed anymore, right? -
Frank Nägler commented on patch set 8 08/10/18, 12:29
BackendUtility.php:1562ReplyI guess yes, this looks like hack, and we don't allow HTML in tooltips with this patch.Tooltip.ts:30Replywhy? the new tooltips using the same data attributes and we remove the old JS stuff. What is the use case which would break?Tooltip.js:16Replycorrect, it is not bootstrap anymoreTypoScriptTemplateObjectBrowserModuleFunctionController.php:379Replyyes, looks like we can remove it -
Andreas Kienast commented on patch set 8 CR 0 08/16/18, 09:55
Tooltip.ts:30Reply UnresolvedAlright, then let's do this. -
Frank Nägler uploaded patch set 9 08/16/18, 10:04
-
Frank Nägler uploaded patch set 10 08/16/18, 10:06
-
TYPO3com voted on patch set 9 V +1 08/16/18, 10:12 Completed build in 07m 56s on Thu, 16 Aug, 12:12 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26645
-
TYPO3com voted on patch set 10 V +1 08/16/18, 10:15 Completed build in 09m 25s on Thu, 16 Aug, 12:15 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26646
-
Jan Helke commented on patch set 10 V -1 08/17/18, 12:18
After applying the patch, I have a major issue with "jumping" icons in the list view. Some Icons jump up, some a big leap to the right. Chrome Version 67.0.3396.99 -
Frank Nägler commented on patch set 10 08/20/18, 07:10
can't reproduce, can you create a screenshot or video and updoad it e.g. to the ticket. -
Paweł Rogowicz commented on patch set 10 V -1 08/26/18, 09:41
I added video with jumping icons to task -
Frank Nägler commented on patch set 10 08/26/18, 10:26
thx for the video, looks like the problem is other CSS, but I will try to fix with this patch. -
Paweł Rogowicz commented on patch set 10 08/27/18, 06:03
> thx for the video, looks like the problem is other CSS, but I will > try to fix with this patch. I think the problem is in this patch, try change style in .tooltip from position relative to absolute in file _element_tooltip.scss, but leave relative in [data-toggle="tooltip"]_element_tooltip.scss:7I think you should add position absolute for .tooltip, because when position is relative then icons jumping in categories -
Frank Nägler uploaded patch set 11 10/02/18, 08:43
-
Frank Nägler commented on patch set 11 CR -2 10/02/18, 08:43
blocked until v9 branching -
TYPO3com voted on patch set 11 V -1 10/02/18, 08:56 Completed build in 13m 13s on Tue, 2 Oct, 10:56 AM Test Summary: 5 of 38154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29270
-
Benni Mack wrote 10/29/18, 09:41
Removed reviewer Benni Mack. -
Frank Nägler abandoned the change 01/18/19, 20:20
_element_tooltip.scss:58Unresolved