Review main Abandoned

55981[FEATURE] Replace TYPO3/CMS/Backend/Tooltip with a pure CSS solution

Frank Nägler CR 0 V 0 Hard +300 −118 updated 01/18/19, 20:20

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 38

Show 18 more files

Review log 2637

Show 712 earlier messages
  1. Frank Nägler uploaded patch set 1 03/01/18, 22:47

  2. TYPO3com voted on patch set 1 V -1 03/01/18, 22:55 Completed build in 08m 46s on Thu, 1 Mar, 11:55 PM Test Summary: 20 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20410

  3. Frank Nägler uploaded patch set 2 03/14/18, 11:02

  4. TYPO3com voted on patch set 2 V -1 03/14/18, 11:10 Completed build in 07m 55s on Wed, 14 Mar, 12:10 PM Test Summary: 20 of 31023 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20918

  5. Frank Nägler uploaded patch set 3 08/06/18, 21:24

  6. Frank Nägler uploaded patch set 4 08/06/18, 21:26

  7. TYPO3com voted on patch set 3 V -1 08/06/18, 21:32 Completed build in 08m 07s on Mon, 6 Aug, 11:32 PM Test Summary: 32 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26235

  8. TYPO3com voted on patch set 4 V -1 08/06/18, 21:34 Completed build in 07m 48s on Mon, 6 Aug, 11:34 PM Test Summary: 32 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26236

  9. Frank Nägler uploaded patch set 5 08/06/18, 21:57

  10. TYPO3com voted on patch set 5 V -1 08/06/18, 22:04 Completed build in 06m 30s on Tue, 7 Aug, 12:04 AM Test Summary: 15 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26237

  11. Frank Nägler uploaded patch set 6 08/06/18, 22:12

  12. Frank Nägler voted on patch set 5 CR -2 08/06/18, 22:14

  1. Frank Nägler voted on patch set 6 CR -2 08/06/18, 22:14

  2. TYPO3com voted on patch set 6 V -1 08/06/18, 22:19 Completed build in 07m 12s on Tue, 7 Aug, 12:19 AM Test Summary: 8 of 33834 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26238

  3. Frank Nägler uploaded patch set 7 08/06/18, 22:26

  4. TYPO3com voted on patch set 7 V +1 08/06/18, 22:33 Completed build in 06m 35s on Tue, 7 Aug, 12:33 AM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26239

  5. Frank Nägler voted on patch set 7 CR 0 08/06/18, 22:33

  6. Frank Nägler uploaded patch set 8 08/07/18, 06:59

  7. TYPO3com voted on patch set 8 V +1 08/07/18, 07:06 Completed build in 07m 03s on Tue, 7 Aug, 09:06 AM Test Summary: 33675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26240

  8. Andreas Kienast commented on patch set 8 CR -1 08/07/18, 20:13

    _element_tooltip.scss:58 Unresolved

    I'd set the padding to "6px 8px" and add `font-size: 0.8em`. This change would require some adjustments in the positioning.

    _element_tooltip.scss:59 Unresolved

    I opt to have max-width instead. Having 160px is a bit large for displaying "id=42" in the record list. But this makes "stretching" to the maximum available width tricky.

    _element_tooltip.scss:67 Unresolved

    I'd set the line-height to 1.0 and add `font-size: 0.8em`. This change would require some adjustments in the positioning.

    Tooltip.ts:30

    Removing any logic here is a breaking change.
  9. Benni Mack commented on patch set 8 08/08/18, 21:30

    BackendUtility.php:1562

    can we safely remove the <br> logic?

    Tooltip.js:16

    comment is outdated, right?

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:379

    method is not needed anymore, right?
  10. Frank Nägler commented on patch set 8 08/10/18, 12:29

    BackendUtility.php:1562 Reply

    I guess yes, this looks like hack, and we don't allow HTML in tooltips with this patch.

    Tooltip.ts:30 Reply

    why? the new tooltips using the same data attributes and we remove the old JS stuff. What is the use case which would break?

    Tooltip.js:16 Reply

    correct, it is not bootstrap anymore

    TypoScriptTemplateObjectBrowserModuleFunctionController.php:379 Reply

    yes, looks like we can remove it
  11. Andreas Kienast commented on patch set 8 CR 0 08/16/18, 09:55

    Tooltip.ts:30 Reply Unresolved

    Alright, then let's do this.
  12. Frank Nägler uploaded patch set 9 08/16/18, 10:04

  13. Frank Nägler uploaded patch set 10 08/16/18, 10:06

  14. TYPO3com voted on patch set 9 V +1 08/16/18, 10:12 Completed build in 07m 56s on Thu, 16 Aug, 12:12 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26645

  15. TYPO3com voted on patch set 10 V +1 08/16/18, 10:15 Completed build in 09m 25s on Thu, 16 Aug, 12:15 PM Test Summary: 34863 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-26646

  16. Jan Helke commented on patch set 10 V -1 08/17/18, 12:18

    After applying the patch, I have a major issue with "jumping" icons in the list view. Some Icons jump up, some a big leap to the right. Chrome Version 67.0.3396.99
  17. Frank Nägler commented on patch set 10 08/20/18, 07:10

    can't reproduce, can you create a screenshot or video and updoad it e.g. to the ticket.
  18. Paweł Rogowicz commented on patch set 10 V -1 08/26/18, 09:41

    I added video with jumping icons to task
  19. Frank Nägler commented on patch set 10 08/26/18, 10:26

    thx for the video, looks like the problem is other CSS, but I will try to fix with this patch.
  20. Paweł Rogowicz commented on patch set 10 08/27/18, 06:03

    > thx for the video, looks like the problem is other CSS, but I will > try to fix with this patch. I think the problem is in this patch, try change style in .tooltip from position relative to absolute in file _element_tooltip.scss, but leave relative in [data-toggle="tooltip"]

    _element_tooltip.scss:7

    I think you should add position absolute for .tooltip, because when position is relative then icons jumping in categories
  21. Frank Nägler uploaded patch set 11 10/02/18, 08:43

  22. Frank Nägler commented on patch set 11 CR -2 10/02/18, 08:43

    blocked until v9 branching
  23. TYPO3com voted on patch set 11 V -1 10/02/18, 08:56 Completed build in 13m 13s on Tue, 2 Oct, 10:56 AM Test Summary: 5 of 38154 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29270

  24. Benni Mack wrote 10/29/18, 09:41

    Removed reviewer Benni Mack.
  25. Frank Nägler abandoned the change 01/18/19, 20:20