55982[BUGFIX] Don't delete referenced files in upload folders on publish
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 1216
-
Benedikt Huss uploaded patch set 1 03/02/18, 07:54
-
TYPO3com voted on patch set 1 V +1 03/02/18, 08:02 Completed build in 08m 21s on Fri, 2 Mar, 09:02 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20415
-
Jörg Bösche voted on patch set 1 CR +1 03/05/18, 09:29
-
Benedikt Huss rebased onto patch set 2 06/22/18, 14:08
-
TYPO3com voted on patch set 2 V +1 06/22/18, 14:20 Completed build in 11m 37s on Fri, 22 Jun, 04:20 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-24617
-
Tymoteusz Motylewski commented on patch set 2 CR -1 06/26/18, 20:03
If I understand the patch correctly, this solves the issue only if other relations to the file are comming from the same table, and from the group field. If the file is referenced from FAL field, or from other table, then the check would fail and the file will be deleted anyway (imagine adding relation in workspaces to existing file, which is already attached to some othe record). Can you confirm my hypothesis? -
Benedikt Huss commented on patch set 2 06/27/18, 09:35
> If I understand the patch correctly, this solves the issue only if > other relations to the file are comming from the same table, and > from the group field. > If the file is referenced from FAL field, or from other table, then > the check would fail and the file will be deleted anyway (imagine > adding relation in workspaces to existing file, which is already > attached to some othe record). > > Can you confirm my hypothesis? I think you're right, there's a comment above my changes: // MISSING: Support for MM file relations! My patch only fixes the problem when using an upload folder. See https://forge.typo3.org/issues/84110 for an example TCA definition. -
Benni Mack wrote 10/26/18, 12:27
Topic set to workspaces -
Benni Mack updated the commit message in patch set 3 11/02/18, 13:07
-
TYPO3com voted on patch set 3 V +1 11/02/18, 13:17 Completed build in 10m 09s on Fri, 2 Nov, 02:17 PM Test Summary: 48419 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-29957
-
Tymoteusz Motylewski commented on patch set 3 11/02/18, 21:15
DataHandler.php:5225UnresolvedWhy the check for the upload folder is needed? What happens when the image was not uploaded directly in the field but just referenced? Will it be deleted too? -
Tymoteusz Motylewski commented on patch set 3 11/02/18, 21:21
> Patch Set 3: Its hard for me to see the full context - whether the patch is just fixing one usage scenario or is it covering all cases. What are the other scenarios we should consider? We dont have to fix everything in this patch, but I would like to see the full picture - when images are removed and its ok, when they are removed but should not and when they are not removed? Adding functional tests for these scenarios would also ease the reviews -
Benni Mack updated the commit message in patch set 4 12/14/18, 10:06
-
TYPO3com voted on patch set 4 V +1 12/14/18, 11:36 Completed build in 41m 09s on Fri, 14 Dec, 12:36 PM Test Summary: 48757 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-30703
-
Susi Moog commented on patch set 4 10/25/19, 18:38
internal_type "file" and type group are deprecated since 9.5 so I would not fix anything anymore that is only relevant for that deprecated use case. -
Benni Mack abandoned the change 12/31/19, 13:17
I'll abandon this change for now. This change cannot go into master, but only in 9.5, so if somebody is intersted in this, should repush to 9.5 branch