Review main Merged

55983[TASK] Improve TranslateViewHelper compiling

Mathias Brodala CR +2 V +2 Easy +1 −7 updated 03/02/18, 11:33

Commit message

Simplify string interpolation with positional arguments.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Mathias Schreiber +1
  • Verified V +2
    • Frank Nägler +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Mathias Brodala uploaded patch set 1 03/02/18, 08:22

  2. TYPO3com voted on patch set 1 V +1 03/02/18, 08:31 Completed build in 09m 10s on Fri, 2 Mar, 09:31 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20416

  3. Mathias Schreiber updated the commit message in patch set 2 03/02/18, 11:11

  4. Mathias Schreiber commented on patch set 2 03/02/18, 11:11

    dropped the "FOLLOWUP" since we no longer wanted to use that.
  5. Mathias Brodala commented on patch set 2 03/02/18, 11:14

    > dropped the "FOLLOWUP" since we no longer wanted to use that. Good to know. Do I need a new Forge ticket in this case?
  6. Mathias Schreiber commented on patch set 2 03/02/18, 11:15

    arguably yes, I don#t know the exact procedure here
  7. TYPO3com voted on patch set 2 V +1 03/02/18, 11:21 Completed build in 09m 20s on Fri, 2 Mar, 12:21 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20424

  8. Mathias Schreiber voted on patch set 2 V +1 CR +1 03/02/18, 11:21

  9. Mathias Schreiber wrote 03/02/18, 11:21

    Removed Verified+1 by Mathias Schreiber <mathias.schreiber@typo3.com>
  10. Frank Nägler voted on patch set 2 V +1 CR +1 03/02/18, 11:30

  11. Mathias Schreiber voted on patch set 2 V +1 03/02/18, 11:32

  12. Frank Nägler voted on patch set 2 V +2 CR +2 03/02/18, 11:33

  13. Frank Nägler merged patch set 3 03/02/18, 11:33