Review main Merged

55986[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

Georg Ringer CR +2 V +2 Easy +0 −1 updated 03/02/18, 15:43

Commit message

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Review

  • Code review CR +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Mathias Brodala +1
  • Verified V +2
    • Frank Nägler +2
    • Daniel Goerz +1
    • Mathias Brodala +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1220

  1. Georg Ringer uploaded patch set 1 03/02/18, 12:19

  2. Daniel Goerz voted on patch set 1 V +1 CR +1 03/02/18, 12:24

  3. TYPO3com voted on patch set 1 V -1 03/02/18, 12:29 Completed build in 09m 41s on Fri, 2 Mar, 01:29 PM Test Summary: 9 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20435

  4. TYPO3com voted on patch set 1 V +1 03/02/18, 12:41 Completed build in 31m 39s on Fri, 2 Mar, 01:41 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20435

  5. Mathias Brodala updated the commit message in patch set 2 03/02/18, 13:25

  6. Mathias Brodala voted on patch set 2 CR +1 03/02/18, 13:25

  7. TYPO3com voted on patch set 2 V -1 03/02/18, 13:34 Completed build in 08m 28s on Fri, 2 Mar, 02:34 PM Test Summary: 10 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20438

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 03/02/18, 13:37

  9. Mathias Brodala voted on patch set 2 V +1 03/02/18, 13:39

  10. TYPO3com commented on patch set 2 03/02/18, 13:40 Completed build in 23m 47s on Fri, 2 Mar, 02:40 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20438

  11. TYPO3com commented on patch set 2 03/02/18, 13:42 Completed build in 40m 35s on Fri, 2 Mar, 02:42 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20438

  12. TYPO3com commented on patch set 2 03/02/18, 13:44 Completed build in 59m 22s on Fri, 2 Mar, 02:44 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20438

  13. Mathias Schreiber updated the commit message in patch set 3 03/02/18, 14:01

  14. TYPO3com voted on patch set 3 V -1 03/02/18, 14:10 Completed build in 09m 05s on Fri, 2 Mar, 03:10 PM Test Summary: 1 of 31032 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20440

  15. TYPO3com voted on patch set 3 V +1 03/02/18, 14:12 Completed build in 20m 28s on Fri, 2 Mar, 03:12 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20440

  16. Daniel Goerz voted on patch set 3 V +1 CR +1 03/02/18, 14:13

  17. Mathias Brodala voted on patch set 3 V +1 CR +1 03/02/18, 14:15

  18. Frank Nägler voted on patch set 3 V +2 CR +2 03/02/18, 15:43

  19. Frank Nägler merged patch set 4 03/02/18, 15:43

  20. Frank Nägler commented on patch set 4 03/02/18, 15:43

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit 8e4e76a9ed8370cbbb9a743f8b24e06c7f392735