Review TYPO3_8-7 Merged

55989[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

Frank Nägler CR +2 V +2 Easy +0 −1 updated 03/02/18, 15:55

Commit message

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Review

  • Code review CR +2
    • Frank Nägler +2
  • Verified V +2
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Frank Nägler commented on patch set 1 03/02/18, 15:43

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/02/18, 15:55 Completed build in 11m 17s on Fri, 2 Mar, 04:55 PM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-1995

  3. Frank Nägler voted on patch set 1 V +2 CR +2 03/02/18, 15:55

  4. Frank Nägler merged patch set 2 03/02/18, 15:55