5599[BUGFIX] Sporadic memcache error on server load
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Steffen Ritter +2
- Markus Klein +1
Issues 1
Files 1
Review log 19
-
Björn Pedersen commented on patch set 1 12/16/11, 13:56
Looks good to me, but someone else must approve Sounds correct to me. -
Markus Klein uploaded patch set 2 12/16/11, 13:56
-
Markus Klein commented on patch set 2 12/16/11, 13:56
Added release 4.7 to commit message. -
Markus Klein commented on patch set 3 12/16/11, 13:56
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 4 12/16/11, 13:56
Verified; Looks good to me, but someone else must approve Took Oliver K.'s comment into account. Since there is no testing possible for "sporadic" errors, also give V:+1. -
Markus Klein uploaded patch set 4 12/16/11, 13:56
-
Oliver Klee commented on patch set 3 12/16/11, 13:56
(1 inline comment)class.t3lib_cache_backend_memcachedbackend.php:274I'd prefer a severity constant getting used instead of the "magic number" 2. -
Oliver Klee commented on patch set 4 12/16/11, 13:56
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 3 12/16/11, 13:56
-
Oliver Hader commented on patch set 3 12/16/11, 13:56
Rebasing to master V:0, R:0 -
Xavier Perseguers commented on patch set 1 12/16/11, 13:56
Looks good to me, but someone else must approve I agree with Steffen G. This is why I added Christian as reviewer and did not give any score for the verified part. -
Steffen Gebert commented on patch set 1 12/16/11, 13:56
IIRC changes to the CF have to go to FLOW3 upstream first (to stay in sync). -
Steffen Ritter commented on patch set 4 V 0 12/16/11, 13:56
by team member; Looks good to me, approved -
Philipp Gampe commented on patch set 1 12/16/11, 13:56
Looks good to me, but someone else must approve Anyone knows a cache where I can test the backend? I do not have a memchache server set up and I would need a test cache which is not used often to test this. -
Mr. Jenkins commented on patch set 1 12/16/11, 13:56
Build Successful http://ci.typo3.org/job/typo3-v4-core-gerrit/2021/ : SUCCESS -
Mr. Jenkins commented on patch set 2 12/16/11, 13:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2510/ : SUCCESS -
Mr. Jenkins commented on patch set 3 12/16/11, 13:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2654/ : SUCCESS -
Mr. Jenkins commented on patch set 4 12/16/11, 13:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2757/ : SUCCESS -
Steffen Ritter merged patch set 4 12/16/11, 13:56