Review main Merged

5599[BUGFIX] Sporadic memcache error on server load

Dmitry Dulepov CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Memcache server sometimes closes connection under heavy load. In
such cases TYPO3 shows error messages in Frontend when setting
the value to cache fails. This should not happen because it is
not such a error that should cause server down times. Change the
exception to a warning in sys_log instead. Admins can see the
error and work on it.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Oliver Klee +1
    • Markus Klein +1
  • Verified V +2
    • Steffen Ritter +2
    • Markus Klein +1

Issues 1

Files 1

Review log 19

  1. Björn Pedersen commented on patch set 1 12/16/11, 13:56

    Looks good to me, but someone else must approve Sounds correct to me.
  2. Markus Klein uploaded patch set 2 12/16/11, 13:56

  3. Markus Klein commented on patch set 2 12/16/11, 13:56

    Added release 4.7 to commit message.
  4. Markus Klein commented on patch set 3 12/16/11, 13:56

    Looks good to me, but someone else must approve
  5. Markus Klein commented on patch set 4 12/16/11, 13:56

    Verified; Looks good to me, but someone else must approve Took Oliver K.'s comment into account. Since there is no testing possible for "sporadic" errors, also give V:+1.
  6. Markus Klein uploaded patch set 4 12/16/11, 13:56

  7. Oliver Klee commented on patch set 3 12/16/11, 13:56

    (1 inline comment)

    class.t3lib_cache_backend_memcachedbackend.php:274

    I'd prefer a severity constant getting used instead of the "magic number" 2.
  8. Oliver Klee commented on patch set 4 12/16/11, 13:56

    Looks good to me, but someone else must approve
  9. Oliver Hader uploaded patch set 3 12/16/11, 13:56

  10. Oliver Hader commented on patch set 3 12/16/11, 13:56

    Rebasing to master V:0, R:0
  11. Xavier Perseguers commented on patch set 1 12/16/11, 13:56

    Looks good to me, but someone else must approve I agree with Steffen G. This is why I added Christian as reviewer and did not give any score for the verified part.
  12. Steffen Gebert commented on patch set 1 12/16/11, 13:56

    IIRC changes to the CF have to go to FLOW3 upstream first (to stay in sync).
  13. Steffen Ritter commented on patch set 4 V 0 12/16/11, 13:56

    by team member; Looks good to me, approved
  14. Philipp Gampe commented on patch set 1 12/16/11, 13:56

    Looks good to me, but someone else must approve Anyone knows a cache where I can test the backend? I do not have a memchache server set up and I would need a test cache which is not used often to test this.
  15. Mr. Jenkins commented on patch set 1 12/16/11, 13:56

  16. Mr. Jenkins commented on patch set 2 12/16/11, 13:56

  17. Mr. Jenkins commented on patch set 3 12/16/11, 13:56

  18. Mr. Jenkins commented on patch set 4 12/16/11, 13:56

  19. Steffen Ritter merged patch set 4 12/16/11, 13:56