Review main Merged

55994[TASK] Remove comments that contain v4 or FLOW information

Benjamin Franzke CR +2 V +2 Normal +56 −116 updated 03/03/18, 21:15

Commit message

Whether a class or functionality is not available or available
differently in v4 or FLOW is not relevant for TYPO3 CMS.
Remove them.

Occurrences have been searched using:
git grep "TYPO3 4"
git grep " v4"
git grep -l "FLOW" | grep php$

Review

  • Code review CR +2
    • Benni Mack +2
    • Mathias Schreiber +1
  • Verified V +2
    • Benni Mack +2
    • Mathias Schreiber +1
    • TYPO3com +1 CI

Issues 1

Files 54

Show 34 more files

Review log 67

  1. Benjamin Franzke uploaded patch set 1 03/03/18, 11:43

  2. Frans Saris commented on patch set 1 03/03/18, 11:51

    Is removing lines like "This file is a backport from FLOW3" in line with the license/copy right?
  3. TYPO3com voted on patch set 1 V +1 03/03/18, 11:52 Completed build in 08m 34s on Sat, 3 Mar, 12:52 PM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20458

  4. Mathias Schreiber voted on patch set 1 V +1 CR +1 03/03/18, 20:54

  5. Benni Mack commented on patch set 1 V +2 CR +2 03/03/18, 21:02

    Since the product name FLOW3 does not exist anymore, seems valid to do so, we also have it in the git commit history (I usually have to go back to the original commit anyways to find 9y old bugs), plus most of the mentioned parts have been refactored anyways...
  6. Benni Mack merged patch set 2 03/03/18, 21:02

  7. Christian Kuhn commented on patch set 2 03/03/18, 21:15

    Locales.php:91

    i think these parts are entirely useless by now, but i'm fiddling in a similar area and may adapt that later with an upcoming patch.

    Locales.php:91

    i think these parts are entirely useless by now, but i'm fiddling in a similar area and may adapt that later with an upcoming patch.