Review main Merged

55997[BUGFIX] Allow multi-byte characters in live search

Markus Klein CR +2 V +2 Easy +1 −1 updated 03/05/18, 08:23

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Markus Klein +1
    • Guido Schmechel +1
    • Andreas Kienast +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Mathias Schreiber +1
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1213

  1. Markus Klein uploaded patch set 1 03/03/18, 23:12

  2. Markus Klein voted on patch set 1 CR +1 03/03/18, 23:13

  3. TYPO3com voted on patch set 1 V +1 03/03/18, 23:21 Completed build in 08m 14s on Sun, 4 Mar, 12:21 AM Test Summary: 30880 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20475

  4. Guido Schmechel commented on patch set 1 V +1 CR +1 03/04/18, 10:10

    Maybe a little more description for the commit message? Code and functionality are fine. (Windows)
  5. Oliver Klee commented on patch set 1 03/04/18, 10:14

    LiveSearch.php:368

    Can we rely on the internal PHP encoding to always be UTF-8 here?
  6. Benni Mack commented on patch set 1 03/04/18, 11:45

    LiveSearch.php:368 Reply

    yes
  7. Andreas Kienast voted on patch set 1 CR +1 03/04/18, 15:11

  8. Wouter Wolters voted on patch set 1 CR +1 03/04/18, 19:47

  9. Mathias Schreiber voted on patch set 1 V +1 CR +1 03/04/18, 20:47

  10. Wouter Wolters voted on patch set 1 V +2 CR +2 03/05/18, 08:20

  11. Wouter Wolters merged patch set 2 03/05/18, 08:20

  12. Wouter Wolters commented on patch set 2 03/05/18, 08:21

    Cherry Picked This patchset was cherry picked to branch TYPO3_8-7 as commit f8b5e40fb2f32885fcf30b77ba384d5256f6b759
  13. Stefan Neufeind commented on patch set 2 V +1 CR +1 03/05/18, 08:23

    worked for me with and without the patch, maybe due to php 7.2.x or something