5600[BUGFIX] Sporadic memcache error on server load
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Oliver Klee +1
- Wouter Wolters +1
- Markus Klein +1
-
Verified V +2
- Georg Ringer +2
- Markus Klein +1
Files 1
Review log 29
Show 4 earlier messages
-
Dmitry Dulepov uploaded patch set 2 02/12/12, 10:12
-
Dmitry Dulepov commented on patch set 2 02/12/12, 10:12
No idea why the second change was pushed :( There was no change on my side in this patch. -
Stefan Neufeind commented on patch set 1 02/12/12, 10:12
Looks good to me, but someone else must approve turning that exception into a logentry makes sense for the described cases imho please note before commit: whitespace at fileend -
Markus Klein commented on patch set 2 02/12/12, 10:12
I guess because of the needed by https://review.typo3.org/6710 dependency
-
Stefan Neufeind commented on patch set 3 02/12/12, 10:12
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 3 02/12/12, 10:12
-
Markus Klein commented on patch set 3 02/12/12, 10:12
Added 4.7 to commit message and corrected Topic number. -
Stefan Neufeind commented on patch set 4 02/12/12, 10:12
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 4 02/12/12, 10:12
-
Oliver Klee commented on patch set 3 02/12/12, 10:12
I would prefer that you didn't submit thisclass.t3lib_cache_backend_memcachedbackend.php:285I'd prefer having a severity constant here instead of the "magic number" 2. -
Oliver Klee commented on patch set 4 02/12/12, 10:12
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 5 02/12/12, 10:12
I would prefer that you didn't submit this Wait for master please. https://review.typo3.org/5599 -
Markus Klein commented on patch set 5 02/12/12, 10:12
No score -
Markus Klein commented on patch set 6 02/12/12, 10:12
Verified; Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 6 02/12/12, 10:12
-
Markus Klein uploaded patch set 7 02/12/12, 10:12
-
Markus Klein commented on patch set 7 02/12/12, 10:12
Verified; Looks good to me, but someone else must approve Adapted commit message to be identical to master. -
Markus Klein commented on patch set 8 02/12/12, 10:12
Verified; Looks good to me, but someone else must approve Resolves -> Fixes -
Markus Klein uploaded patch set 8 02/12/12, 10:12
-
Oliver Klee commented on patch set 5 02/12/12, 10:12
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 8 02/12/12, 10:12
Looks good to me, but someone else must approve -
Oliver Hader uploaded patch set 5 02/12/12, 10:12
-
Oliver Hader commented on patch set 5 02/12/12, 10:12
Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Oliver Klee <typo3-coding@oliverklee.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> -
Georg Ringer commented on patch set 3 02/12/12, 10:12
(1 inline comment)class.t3lib_cache_backend_memcachedbackend.php:285Replyt3lib_div::SYSLOG_SEVERITY_WARNING I guess -
Georg Ringer commented on patch set 4 02/12/12, 10:12
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 8 V 0 02/12/12, 10:12
by team member; Looks good to me, approved -
Mr. Jenkins commented on patch set 1 02/12/12, 10:12
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/364/ : SUCCESS -
Wouter Wolters commented on patch set 8 02/12/12, 10:12
Looks good to me, but someone else must approve -
Georg Ringer merged patch set 8 02/12/12, 10:12