Review TYPO3_4-5 Merged

5600[BUGFIX] Sporadic memcache error on server load

Dmitry Dulepov CR +2 V +2 Easy +4 −4 updated 06/03/13, 20:49

Commit message

Memcache server sometimes closes connection under heavy load. In
such cases TYPO3 shows error messages in Frontend when setting
the value to cache fails. This should not happen because it is
not such a error that should cause server down times. Change the
exception to a warning in sys_log instead. Admins can see the
error and work on it.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Wouter Wolters +1
    • Markus Klein +1
  • Verified V +2
    • Georg Ringer +2
    • Markus Klein +1

Files 1

Review log 29

Show 4 earlier messages
  1. Dmitry Dulepov uploaded patch set 2 02/12/12, 10:12

  2. Dmitry Dulepov commented on patch set 2 02/12/12, 10:12

    No idea why the second change was pushed :( There was no change on my side in this patch.
  3. Stefan Neufeind commented on patch set 1 02/12/12, 10:12

    Looks good to me, but someone else must approve turning that exception into a logentry makes sense for the described cases imho please note before commit: whitespace at fileend
  4. Markus Klein commented on patch set 2 02/12/12, 10:12

    I guess because of the needed by https://review.typo3.org/6710 dependency
  1. Stefan Neufeind commented on patch set 3 02/12/12, 10:12

    Looks good to me, but someone else must approve
  2. Markus Klein uploaded patch set 3 02/12/12, 10:12

  3. Markus Klein commented on patch set 3 02/12/12, 10:12

    Added 4.7 to commit message and corrected Topic number.
  4. Stefan Neufeind commented on patch set 4 02/12/12, 10:12

    Looks good to me, but someone else must approve
  5. Markus Klein uploaded patch set 4 02/12/12, 10:12

  6. Oliver Klee commented on patch set 3 02/12/12, 10:12

    I would prefer that you didn't submit this

    class.t3lib_cache_backend_memcachedbackend.php:285

    I'd prefer having a severity constant here instead of the "magic number" 2.
  7. Oliver Klee commented on patch set 4 02/12/12, 10:12

    Looks good to me, but someone else must approve
  8. Markus Klein commented on patch set 5 02/12/12, 10:12

    I would prefer that you didn't submit this Wait for master please. https://review.typo3.org/5599
  9. Markus Klein commented on patch set 5 02/12/12, 10:12

    No score
  10. Markus Klein commented on patch set 6 02/12/12, 10:12

    Verified; Looks good to me, but someone else must approve
  11. Markus Klein uploaded patch set 6 02/12/12, 10:12

  12. Markus Klein uploaded patch set 7 02/12/12, 10:12

  13. Markus Klein commented on patch set 7 02/12/12, 10:12

    Verified; Looks good to me, but someone else must approve Adapted commit message to be identical to master.
  14. Markus Klein commented on patch set 8 02/12/12, 10:12

    Verified; Looks good to me, but someone else must approve Resolves -> Fixes
  15. Markus Klein uploaded patch set 8 02/12/12, 10:12

  16. Oliver Klee commented on patch set 5 02/12/12, 10:12

    Looks good to me, but someone else must approve
  17. Oliver Klee commented on patch set 8 02/12/12, 10:12

    Looks good to me, but someone else must approve
  18. Oliver Hader uploaded patch set 5 02/12/12, 10:12

  19. Oliver Hader commented on patch set 5 02/12/12, 10:12

    Looks good to me, but someone else must approve Automated rebasing to TYPO3_4-5 - Please consider updating your reviews V:0, R:1 as a summary of previous scores (limited to [-1;+1]) V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Oliver Klee <typo3-coding@oliverklee.de> V:0, R:1 from Georg Ringer <mail@ringerge.org>
  20. Georg Ringer commented on patch set 3 02/12/12, 10:12

    (1 inline comment)

    class.t3lib_cache_backend_memcachedbackend.php:285 Reply

    t3lib_div::SYSLOG_SEVERITY_WARNING I guess
  21. Georg Ringer commented on patch set 4 02/12/12, 10:12

    Looks good to me, but someone else must approve
  22. Georg Ringer commented on patch set 8 V 0 02/12/12, 10:12

    by team member; Looks good to me, approved
  23. Mr. Jenkins commented on patch set 1 02/12/12, 10:12

  24. Wouter Wolters commented on patch set 8 02/12/12, 10:12

    Looks good to me, but someone else must approve
  25. Georg Ringer merged patch set 8 02/12/12, 10:12