Review main Merged

56006[TASK] Cleanup code imports for all workspaces classes

Benni Mack CR +2 V +2 Hard +275 −280 updated 03/05/18, 12:41

Commit message

The system extension workspaces was never touched in terms of
checking if actually methods are needed, and a lot of code still uses
FQDN instead of the "use" keyword for a PHP class.

Some unused dependencies (e.g. to Extbase's objectmanager) are
removed as well.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • Jörg Bösche +1
    • Oliver Hader +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 1314

  1. Benni Mack uploaded patch set 1 03/05/18, 06:42

  2. TYPO3com voted on patch set 1 V +1 03/05/18, 06:53 Completed build in 10m 38s on Mon, 5 Mar, 07:53 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20520

  3. Georg Ringer voted on patch set 1 V +1 CR +1 03/05/18, 07:12

  4. Jörg Bösche commented on patch set 1 03/05/18, 07:19

    What about strict return types in the class methods? protected function getBackendUser(): BackendUserAuthentication { }
  5. Tymoteusz Motylewski commented on patch set 1 03/05/18, 07:37

  6. Benni Mack commented on patch set 1 03/05/18, 07:57

    @Joerg: I plan on cleaning up further (not just code beauty) in the next months, and would like to add the strict types when actually testing the different functionalities then (as I expect that more code will be removed in v9)
  7. Stefan Neufeind commented on patch set 1 V +1 CR +1 03/05/18, 08:12

    AjaxDispatcher.php:45

    Change in behaviour. The GuzzleHttp-variant throws exceptions on error.
  8. Wouter Wolters voted on patch set 1 CR +1 03/05/18, 08:16

  9. Jörg Bösche voted on patch set 1 CR +1 03/05/18, 08:24

  10. Wouter Wolters voted on patch set 1 V +2 CR +2 03/05/18, 08:34

  11. Wouter Wolters merged patch set 2 03/05/18, 08:34

  12. Benni Mack commented on patch set 1 03/05/18, 08:35

    AjaxDispatcher.php:45 Reply

    that was a classic misbehaviour from the "ExtDirect" migration. Stay tuned as we're going to rework this with full PSR-7 for AJAX calls anyways.
  13. Oliver Hader commented on patch set 1 03/05/18, 12:41

    BackendUtilityHook.php:28 Reply

    Looks good to me, the hook class does not have any internal state. The Singleton thus has been used for "performance reasons" only, but not within the scope of a traditional creational design pattern in OOP.
  14. Oliver Hader voted on patch set 2 CR +1 03/05/18, 12:41