56006[TASK] Cleanup code imports for all workspaces classes
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Georg Ringer +1
- Jörg Bösche +1
- Oliver Hader +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 29
- typo3/sysext/workspaces/Classes/Backend/ToolbarItems/WorkspaceSelectorToolbarItem.php+2 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/AbstractHandler.php+14 −9
- typo3/sysext/workspaces/Classes/Controller/Remote/ActionHandler.php+16 −32
- typo3/sysext/workspaces/Classes/Controller/Remote/MassActionHandler.php+4 −2
- typo3/sysext/workspaces/Classes/Controller/Remote/RemoteServer.php+0 −10
- typo3/sysext/workspaces/Classes/Controller/AjaxController.php+4 −2
- typo3/sysext/workspaces/Classes/Controller/AjaxDispatcher.php2+1 −1
- typo3/sysext/workspaces/Classes/Controller/PreviewController.php+2 −1
- typo3/sysext/workspaces/Classes/Controller/ReviewController.php+0 −2
- typo3/sysext/workspaces/Classes/DataHandler/CommandMap.php+41 −37
- typo3/sysext/workspaces/Classes/Dependency/DependencyEntityFactory.php+13 −12
- typo3/sysext/workspaces/Classes/Dependency/DependencyResolver.php+17 −15
- typo3/sysext/workspaces/Classes/Dependency/ElementEntity.php+9 −8
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+5 −4
- typo3/sysext/workspaces/Classes/Dependency/ReferenceEntity.php+4 −4
- typo3/sysext/workspaces/Classes/Domain/Model/CombinedRecord.php+14 −12
- typo3/sysext/workspaces/Classes/Domain/Model/DatabaseRecord.php+8 −5
- typo3/sysext/workspaces/Classes/Hook/BackendUtilityHook.php2+1 −12
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+23 −20
- typo3/sysext/workspaces/Classes/Service/Dependency/CollectionService.php+4 −3
Show 9 more files
- typo3/sysext/workspaces/Classes/Service/AdditionalColumnService.php+16 −10
- typo3/sysext/workspaces/Classes/Service/AdditionalResourceService.php+9 −6
- typo3/sysext/workspaces/Classes/Service/AutoPublishService.php+3 −2
- typo3/sysext/workspaces/Classes/Service/GridDataService.php+24 −22
- typo3/sysext/workspaces/Classes/Service/HistoryService.php+10 −8
- typo3/sysext/workspaces/Classes/Service/IntegrityService.php+10 −8
- typo3/sysext/workspaces/Classes/Service/RecordService.php+2 −1
- typo3/sysext/workspaces/Classes/Service/StagesService.php+14 −16
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+5 −14
Review log 1314
-
Benni Mack uploaded patch set 1 03/05/18, 06:42
-
TYPO3com voted on patch set 1 V +1 03/05/18, 06:53 Completed build in 10m 38s on Mon, 5 Mar, 07:53 AM Test Summary: 30881 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20520
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/05/18, 07:12
-
Jörg Bösche commented on patch set 1 03/05/18, 07:19
What about strict return types in the class methods? protected function getBackendUser(): BackendUserAuthentication { } -
Tymoteusz Motylewski commented on patch set 1 03/05/18, 07:37
BackendUtilityHook.php:28sidenote, the singleton was introduced in https://github.com/TYPO3/TYPO3.CMS/commit/6860007ed056a99b55f9352f79965e83cd0dcddc#diff-5555add86f5d81800393ce48cf7cf6e1 -
Benni Mack commented on patch set 1 03/05/18, 07:57
@Joerg: I plan on cleaning up further (not just code beauty) in the next months, and would like to add the strict types when actually testing the different functionalities then (as I expect that more code will be removed in v9) -
Stefan Neufeind commented on patch set 1 V +1 CR +1 03/05/18, 08:12
AjaxDispatcher.php:45Change in behaviour. The GuzzleHttp-variant throws exceptions on error. -
Wouter Wolters voted on patch set 1 CR +1 03/05/18, 08:16
-
Jörg Bösche voted on patch set 1 CR +1 03/05/18, 08:24
-
Wouter Wolters voted on patch set 1 V +2 CR +2 03/05/18, 08:34
-
Wouter Wolters merged patch set 2 03/05/18, 08:34
-
Benni Mack commented on patch set 1 03/05/18, 08:35
AjaxDispatcher.php:45Replythat was a classic misbehaviour from the "ExtDirect" migration. Stay tuned as we're going to rework this with full PSR-7 for AJAX calls anyways. -
Oliver Hader commented on patch set 1 03/05/18, 12:41
BackendUtilityHook.php:28ReplyLooks good to me, the hook class does not have any internal state. The Singleton thus has been used for "performance reasons" only, but not within the scope of a traditional creational design pattern in OOP. -
Oliver Hader voted on patch set 2 CR +1 03/05/18, 12:41