Review main Merged

56013[TASK] bamboo: Hard kill php web server processes

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 03/05/18, 16:13

Commit message

bamboo acceptance test shut down sometimes fails to stop
the 'php -S' web server process for unknown reasons.
A next job on the same agent then fails to bind to the
port, leading to broken builds.
Switch from SIGTERM to SIGKILL during test shut down
to see if that improves the situation.

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 03/05/18, 15:43

  2. Christian Kuhn commented on patch set 1 03/05/18, 15:48

    plan rollout done already for master & v8. will wait for bamboo and merge later.
  3. TYPO3com voted on patch set 1 V +1 03/05/18, 15:53 Completed build in 09m 01s on Mon, 5 Mar, 04:53 PM Test Summary: 30806 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-20547

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/05/18, 16:13

  5. Christian Kuhn merged patch set 2 03/05/18, 16:13