Review TYPO3_8-7 Merged

56019[BUGFIX] RootlineUtility only resolves defined relation fields

Jigal van Hemert CR +2 V +2 Easy +22 −1 updated 03/06/18, 07:10

Commit message

The RootlineUtility first selects all fields, which have been added
via the config option "addRootLineFields". After that, it iterates
over all(!) columns that are defined as relation.

The change modifies the loop so that only relations are resolved for
field pages.media (predefined) and those fields that have been added
to $GLOBALS[TYPO3_CONF_VARS][FE][addRootLineFields].

Review

  • Code review CR +2
    • Georg Ringer +2
    • Jigal van Hemert +1
  • Verified V +2
    • Georg Ringer +2
    • Jigal van Hemert +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 57

  1. Jigal van Hemert commented on patch set 1 03/06/18, 06:43

    Cherry Picked from branch master.
  2. Benni Mack commented on patch set 2 03/06/18, 06:48

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V +1 03/06/18, 06:54 Completed build in 10m 38s on Tue, 6 Mar, 07:54 AM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2012

  4. TYPO3com voted on patch set 2 V +1 03/06/18, 07:02 Completed build in 14m 12s on Tue, 6 Mar, 08:02 AM Test Summary: 58125 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-2013

  5. Jigal van Hemert voted on patch set 2 V +1 CR +1 03/06/18, 07:04

  6. Georg Ringer voted on patch set 2 V +2 CR +2 03/06/18, 07:10

  7. Georg Ringer merged patch set 3 03/06/18, 07:10